Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reexport protocol modules from aztec-nr. #3590

Closed
LHerskind opened this issue Dec 5, 2023 · 0 comments · Fixed by #3926
Closed

Reexport protocol modules from aztec-nr. #3590

LHerskind opened this issue Dec 5, 2023 · 0 comments · Fixed by #3926
Labels
S-blocked Status: Blocked

Comments

@LHerskind
Copy link
Contributor

LHerskind commented Dec 5, 2023 •
edited by benesjan
Loading

When working on #3589 ran into an issue when reexporting modules in noir.

I was moving the constants_gen into noir-protocol-circuits and wanted to just re-export it from aztec-nr to make the importing easy, but it seemed like it was broken. Had a quick view from @kevaundray as well.

Blocked by noir-lang/noir#3889

Note: Once addressing this look for a link of this issue in the codebase and address the comments containing the link.
@LHerskind LHerskind added the S-blocked Status: Blocked label Dec 5, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Dec 5, 2023
@LHerskind LHerskind mentioned this issue Dec 5, 2023
Merged
4 tasks
benesjan pushed a commit that referenced this issue Dec 6, 2023
@LHerskind
refactor: Make noir-circuit independent of aztec-nr (#3591)
3013354 
Fixes #3589 by adding constants to `protocol-circuits` and removing them
from `aztec-nr`. The importing looks a bit clunky after since reexports
of modules did not seem to work in noir #3590.
@TomAFrench TomAFrench mentioned this issue Jan 12, 2024
Merged
TomAFrench added a commit that referenced this issue Jan 12, 2024
@TomAFrench
feat: reexport protocol_types from aztec-nr (#3926)
9bd22f7 
This PR rexports `protocol_types` from `aztec-nr` so that users of
`aztec-nr` don't need to have a direct dependency on `protocol_types`

Closes #3590
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Jan 12, 2024
AztecBot pushed a commit to AztecProtocol/aztec-nr that referenced this issue Jan 18, 2024
@TomAFrench @AztecBot
feat: reexport protocol_types from aztec-nr (#3926)
84a4e6c 
This PR rexports `protocol_types` from `aztec-nr` so that users of
`aztec-nr` don't need to have a direct dependency on `protocol_types`

Closes AztecProtocol/aztec-packages#3590
@alexghr alexghr mentioned this issue Feb 5, 2024
Merged
michaelelliot pushed a commit to Swoir/noir_rs that referenced this issue Feb 28, 2024
@TomAFrench
feat: reexport protocol_types from aztec-nr (AztecProtocol#3926)
1e9ba84 
This PR rexports `protocol_types` from `aztec-nr` so that users of
`aztec-nr` don't need to have a direct dependency on `protocol_types`

Closes AztecProtocol#3590
superstar0402 added a commit to superstar0402/aztec-nr that referenced this issue Aug 16, 2024
@superstar0402
feat: reexport protocol_types from aztec-nr (#3926)
33841a2 
This PR rexports `protocol_types` from `aztec-nr` so that users of
`aztec-nr` don't need to have a direct dependency on `protocol_types`

Closes AztecProtocol/aztec-packages#3590
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
S-blocked Status: Blocked
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: reexport protocol_types from aztec-nr AztecProtocol/aztec-packages
1 participant
@LHerskind