Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove bn254 instantiation of eccvm plus naming changes #3330

Merged
merged 1 commit into from
Nov 16, 2023
Merged

chore: Remove bn254 instantiation of eccvm plus naming changes #3330

merged 1 commit into from
Nov 16, 2023

Conversation

ledwards2225
Copy link
Contributor

@ledwards2225 ledwards2225 commented Nov 16, 2023 •
edited
Loading

Removing bn254 ECCVM instantiation plus some minor naming changes and cleanup. (Split out from larger PR by @codygunton)

Checklist:

Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.

  • If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag.
  • I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code.
  • Every change is related to the PR description.
  • I have linked this pull request to relevant issues (if any exist).

@ledwards2225 ledwards2225 marked this pull request as ready for review November 16, 2023 21:35
@ledwards2225 ledwards2225 self-assigned this Nov 16, 2023
codygunton
codygunton approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@codygunton codygunton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, better to split this out

@codygunton codygunton enabled auto-merge (squash) November 16, 2023 21:51
@codygunton codygunton merged commit 23d1e2d into master Nov 16, 2023
79 checks passed
@codygunton codygunton deleted the lde/eccvm_grump_only branch November 16, 2023 22:02
@AztecBot AztecBot mentioned this pull request Nov 16, 2023
Merged
ludamad pushed a commit that referenced this pull request Nov 17, 2023
@AztecBot
chore(master): Release 0.15.0 (#3269)
dd8ea9c 
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.15.0</summary>

##
[0.15.0](aztec-packages-v0.14.2...aztec-packages-v0.15.0)
(2023-11-16)


### ⚠ BREAKING CHANGES

* Replace computing hashes in circuits wasm, with computing them in ts
via bb.js pedersen call.
([#3114](#3114))

### Features

* **bb:** Add msan preset
([#3284](#3284))
([bcf025c](bcf025c))
* Enable merge and root rollup circuits in noir
([#3248](#3248))
([68555fc](68555fc))
* Protogalaxy combiner quotient
([#3245](#3245))
([db0f3ab](db0f3ab))
* Public kernel in noir
([#3186](#3186))
([15a522b](15a522b))
* Ultra honk arith from ultra
([#3274](#3274))
([ec2b805](ec2b805))


### Bug Fixes

* Debug build
([#3283](#3283))
([aca2624](aca2624))
* Fix block constraint key divergence bug.
([#3256](#3256))
([1c71a0c](1c71a0c))
* Main.md typo
([#3278](#3278))
([cb87c4d](cb87c4d))
* Typo fix roundup
([#3302](#3302))
([9dd778d](9dd778d))


### Miscellaneous

* **bb:** Remove -Wfatal-errors
([#3318](#3318))
([4229173](4229173))
* Clarify that barretenberg mirror should not take PRs
([#3303](#3303))
([13f1a1d](13f1a1d))
* Clean up Plonk widgets
([#3305](#3305))
([4623d91](4623d91))
* **docs:** Aztec.nr logging page
([#3281](#3281))
([11e6ca7](11e6ca7))
* **docs:** Update netlify.toml and fix build
([#3304](#3304))
([df76636](df76636))
* Explicitly instantiate Goblin translator relations
([#3239](#3239))
([e3b5fb0](e3b5fb0))
* Plain struct flavor entities
([#3277](#3277))
([f109512](f109512))
* Remove bn254 instantiation of eccvm plus naming changes
([#3330](#3330))
([23d1e2d](23d1e2d))
* Replace computing hashes in circuits wasm, with computing them in ts
via bb.js pedersen call.
([#3114](#3114))
([87eeb71](87eeb71))
* Revert build-debug folder for debug preset
([#3324](#3324))
([43a2e6b](43a2e6b))
* Towards plain struct flavor entities
([#3216](#3216))
([3ba89cf](3ba89cf))
* Typo fixes based on cspell
([#3319](#3319))
([8ae44dd](8ae44dd))
</details>

<details><summary>barretenberg.js: 0.15.0</summary>

##
[0.15.0](barretenberg.js-v0.14.2...barretenberg.js-v0.15.0)
(2023-11-16)


### ⚠ BREAKING CHANGES

* Replace computing hashes in circuits wasm, with computing them in ts
via bb.js pedersen call.
([#3114](#3114))

### Bug Fixes

* Fix block constraint key divergence bug.
([#3256](#3256))
([1c71a0c](1c71a0c))


### Miscellaneous

* Replace computing hashes in circuits wasm, with computing them in ts
via bb.js pedersen call.
([#3114](#3114))
([87eeb71](87eeb71))
* Typo fixes based on cspell
([#3319](#3319))
([8ae44dd](8ae44dd))
</details>

<details><summary>barretenberg: 0.15.0</summary>

##
[0.15.0](barretenberg-v0.14.2...barretenberg-v0.15.0)
(2023-11-16)


### ⚠ BREAKING CHANGES

* Replace computing hashes in circuits wasm, with computing them in ts
via bb.js pedersen call.
([#3114](#3114))

### Features

* **bb:** Add msan preset
([#3284](#3284))
([bcf025c](bcf025c))
* Protogalaxy combiner quotient
([#3245](#3245))
([db0f3ab](db0f3ab))
* Ultra honk arith from ultra
([#3274](#3274))
([ec2b805](ec2b805))


### Bug Fixes

* Debug build
([#3283](#3283))
([aca2624](aca2624))
* Fix block constraint key divergence bug.
([#3256](#3256))
([1c71a0c](1c71a0c))


### Miscellaneous

* **bb:** Remove -Wfatal-errors
([#3318](#3318))
([4229173](4229173))
* Clarify that barretenberg mirror should not take PRs
([#3303](#3303))
([13f1a1d](13f1a1d))
* Clean up Plonk widgets
([#3305](#3305))
([4623d91](4623d91))
* Explicitly instantiate Goblin translator relations
([#3239](#3239))
([e3b5fb0](e3b5fb0))
* Plain struct flavor entities
([#3277](#3277))
([f109512](f109512))
* Remove bn254 instantiation of eccvm plus naming changes
([#3330](#3330))
([23d1e2d](23d1e2d))
* Replace computing hashes in circuits wasm, with computing them in ts
via bb.js pedersen call.
([#3114](#3114))
([87eeb71](87eeb71))
* Revert build-debug folder for debug preset
([#3324](#3324))
([43a2e6b](43a2e6b))
* Towards plain struct flavor entities
([#3216](#3216))
([3ba89cf](3ba89cf))
* Typo fixes based on cspell
([#3319](#3319))
([8ae44dd](8ae44dd))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@codygunton codygunton mentioned this pull request Nov 17, 2023
Closed
4 tasks
AztecBot added a commit to AztecProtocol/barretenberg that referenced this pull request Nov 19, 2023
@AztecBot
chore(master): Release 0.15.0 (#3269)
ffdc351 
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.15.0</summary>

##
[0.15.0](AztecProtocol/aztec-packages@aztec-packages-v0.14.2...aztec-packages-v0.15.0)
(2023-11-16)


### ⚠ BREAKING CHANGES

* Replace computing hashes in circuits wasm, with computing them in ts
via bb.js pedersen call.
([#3114](AztecProtocol/aztec-packages#3114))

### Features

* **bb:** Add msan preset
([#3284](AztecProtocol/aztec-packages#3284))
([bcf025c](AztecProtocol/aztec-packages@bcf025c))
* Enable merge and root rollup circuits in noir
([#3248](AztecProtocol/aztec-packages#3248))
([68555fc](AztecProtocol/aztec-packages@68555fc))
* Protogalaxy combiner quotient
([#3245](AztecProtocol/aztec-packages#3245))
([db0f3ab](AztecProtocol/aztec-packages@db0f3ab))
* Public kernel in noir
([#3186](AztecProtocol/aztec-packages#3186))
([15a522b](AztecProtocol/aztec-packages@15a522b))
* Ultra honk arith from ultra
([#3274](AztecProtocol/aztec-packages#3274))
([ec2b805](AztecProtocol/aztec-packages@ec2b805))


### Bug Fixes

* Debug build
([#3283](AztecProtocol/aztec-packages#3283))
([aca2624](AztecProtocol/aztec-packages@aca2624))
* Fix block constraint key divergence bug.
([#3256](AztecProtocol/aztec-packages#3256))
([1c71a0c](AztecProtocol/aztec-packages@1c71a0c))
* Main.md typo
([#3278](AztecProtocol/aztec-packages#3278))
([cb87c4d](AztecProtocol/aztec-packages@cb87c4d))
* Typo fix roundup
([#3302](AztecProtocol/aztec-packages#3302))
([9dd778d](AztecProtocol/aztec-packages@9dd778d))


### Miscellaneous

* **bb:** Remove -Wfatal-errors
([#3318](AztecProtocol/aztec-packages#3318))
([4229173](AztecProtocol/aztec-packages@4229173))
* Clarify that barretenberg mirror should not take PRs
([#3303](AztecProtocol/aztec-packages#3303))
([13f1a1d](AztecProtocol/aztec-packages@13f1a1d))
* Clean up Plonk widgets
([#3305](AztecProtocol/aztec-packages#3305))
([4623d91](AztecProtocol/aztec-packages@4623d91))
* **docs:** Aztec.nr logging page
([#3281](AztecProtocol/aztec-packages#3281))
([11e6ca7](AztecProtocol/aztec-packages@11e6ca7))
* **docs:** Update netlify.toml and fix build
([#3304](AztecProtocol/aztec-packages#3304))
([df76636](AztecProtocol/aztec-packages@df76636))
* Explicitly instantiate Goblin translator relations
([#3239](AztecProtocol/aztec-packages#3239))
([e3b5fb0](AztecProtocol/aztec-packages@e3b5fb0))
* Plain struct flavor entities
([#3277](AztecProtocol/aztec-packages#3277))
([f109512](AztecProtocol/aztec-packages@f109512))
* Remove bn254 instantiation of eccvm plus naming changes
([#3330](AztecProtocol/aztec-packages#3330))
([23d1e2d](AztecProtocol/aztec-packages@23d1e2d))
* Replace computing hashes in circuits wasm, with computing them in ts
via bb.js pedersen call.
([#3114](AztecProtocol/aztec-packages#3114))
([87eeb71](AztecProtocol/aztec-packages@87eeb71))
* Revert build-debug folder for debug preset
([#3324](AztecProtocol/aztec-packages#3324))
([43a2e6b](AztecProtocol/aztec-packages@43a2e6b))
* Towards plain struct flavor entities
([#3216](AztecProtocol/aztec-packages#3216))
([3ba89cf](AztecProtocol/aztec-packages@3ba89cf))
* Typo fixes based on cspell
([#3319](AztecProtocol/aztec-packages#3319))
([8ae44dd](AztecProtocol/aztec-packages@8ae44dd))
</details>

<details><summary>barretenberg.js: 0.15.0</summary>

##
[0.15.0](AztecProtocol/aztec-packages@barretenberg.js-v0.14.2...barretenberg.js-v0.15.0)
(2023-11-16)


### ⚠ BREAKING CHANGES

* Replace computing hashes in circuits wasm, with computing them in ts
via bb.js pedersen call.
([#3114](AztecProtocol/aztec-packages#3114))

### Bug Fixes

* Fix block constraint key divergence bug.
([#3256](AztecProtocol/aztec-packages#3256))
([1c71a0c](AztecProtocol/aztec-packages@1c71a0c))


### Miscellaneous

* Replace computing hashes in circuits wasm, with computing them in ts
via bb.js pedersen call.
([#3114](AztecProtocol/aztec-packages#3114))
([87eeb71](AztecProtocol/aztec-packages@87eeb71))
* Typo fixes based on cspell
([#3319](AztecProtocol/aztec-packages#3319))
([8ae44dd](AztecProtocol/aztec-packages@8ae44dd))
</details>

<details><summary>barretenberg: 0.15.0</summary>

##
[0.15.0](AztecProtocol/aztec-packages@barretenberg-v0.14.2...barretenberg-v0.15.0)
(2023-11-16)


### ⚠ BREAKING CHANGES

* Replace computing hashes in circuits wasm, with computing them in ts
via bb.js pedersen call.
([#3114](AztecProtocol/aztec-packages#3114))

### Features

* **bb:** Add msan preset
([#3284](AztecProtocol/aztec-packages#3284))
([bcf025c](AztecProtocol/aztec-packages@bcf025c))
* Protogalaxy combiner quotient
([#3245](AztecProtocol/aztec-packages#3245))
([db0f3ab](AztecProtocol/aztec-packages@db0f3ab))
* Ultra honk arith from ultra
([#3274](AztecProtocol/aztec-packages#3274))
([ec2b805](AztecProtocol/aztec-packages@ec2b805))


### Bug Fixes

* Debug build
([#3283](AztecProtocol/aztec-packages#3283))
([aca2624](AztecProtocol/aztec-packages@aca2624))
* Fix block constraint key divergence bug.
([#3256](AztecProtocol/aztec-packages#3256))
([1c71a0c](AztecProtocol/aztec-packages@1c71a0c))


### Miscellaneous

* **bb:** Remove -Wfatal-errors
([#3318](AztecProtocol/aztec-packages#3318))
([4229173](AztecProtocol/aztec-packages@4229173))
* Clarify that barretenberg mirror should not take PRs
([#3303](AztecProtocol/aztec-packages#3303))
([13f1a1d](AztecProtocol/aztec-packages@13f1a1d))
* Clean up Plonk widgets
([#3305](AztecProtocol/aztec-packages#3305))
([4623d91](AztecProtocol/aztec-packages@4623d91))
* Explicitly instantiate Goblin translator relations
([#3239](AztecProtocol/aztec-packages#3239))
([e3b5fb0](AztecProtocol/aztec-packages@e3b5fb0))
* Plain struct flavor entities
([#3277](AztecProtocol/aztec-packages#3277))
([f109512](AztecProtocol/aztec-packages@f109512))
* Remove bn254 instantiation of eccvm plus naming changes
([#3330](AztecProtocol/aztec-packages#3330))
([23d1e2d](AztecProtocol/aztec-packages@23d1e2d))
* Replace computing hashes in circuits wasm, with computing them in ts
via bb.js pedersen call.
([#3114](AztecProtocol/aztec-packages#3114))
([87eeb71](AztecProtocol/aztec-packages@87eeb71))
* Revert build-debug folder for debug preset
([#3324](AztecProtocol/aztec-packages#3324))
([43a2e6b](AztecProtocol/aztec-packages@43a2e6b))
* Towards plain struct flavor entities
([#3216](AztecProtocol/aztec-packages#3216))
([3ba89cf](AztecProtocol/aztec-packages@3ba89cf))
* Typo fixes based on cspell
([#3319](AztecProtocol/aztec-packages#3319))
([8ae44dd](AztecProtocol/aztec-packages@8ae44dd))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codygunton codygunton codygunton approved these changes

Assignees

@ledwards2225 ledwards2225

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ledwards2225 @codygunton