-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Add noir-protocol-circuits to deploy_npm #3268
Conversation
yarn-project/deploy_npm.sh
Outdated
@@ -81,6 +81,7 @@ deploy_package l1-artifacts | |||
deploy_package ethereum | |||
deploy_package noir-compiler | |||
deploy_package noir-contracts | |||
deploy_package noir-protocol-circuits |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be after merkle-tree
since noir-protocol-circuits depends on that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yes correct, I didn't look at devDependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm It's a devDependency but I'll move it just in case!
@sirasistant could you add a comment saying how packages should be added based on their dependency chart? |
Benchmark resultsMetrics with a significant change:
Detailed resultsAll benchmarks are run on txs on the This benchmark source data is available in JSON format on S3 here. Values are compared against data from master at commit L2 block published to L1Each column represents the number of txs on an L2 block published to L1.
L2 chain processingEach column represents the number of blocks on the L2 chain where each block has 16 txs.
Circuits statsStats on running time and I/O sizes collected for every circuit run across all benchmarks.
MiscellaneousTransaction sizes based on how many contracts are deployed in the tx.
|
🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.14.2</summary> ## [0.14.2](aztec-packages-v0.14.1...aztec-packages-v0.14.2) (2023-11-07) ### Features * Load private tests and docs ([#3243](#3243)) ([f3d8aae](f3d8aae)), closes [#1285](#1285) * Run solidity tests for all acir artifacts ([#3161](#3161)) ([d09f667](d09f667)) ### Bug Fixes * Wait for accounts to catch up with notes when deployed ([#2834](#2834)) ([a8f3119](a8f3119)) ### Miscellaneous * Add noir-protocol-circuits to deploy_npm ([#3268](#3268)) ([1a22cae](1a22cae)) * Aztec-cli better volume mounting strategy ([#3138](#3138)) ([d40460e](d40460e)) * Disable circuits tasks ([#3253](#3253)) ([e8945f8](e8945f8)) </details> <details><summary>barretenberg.js: 0.14.2</summary> ## [0.14.2](barretenberg.js-v0.14.1...barretenberg.js-v0.14.2) (2023-11-07) ### Features * Run solidity tests for all acir artifacts ([#3161](#3161)) ([d09f667](d09f667)) </details> <details><summary>barretenberg: 0.14.2</summary> ## [0.14.2](barretenberg-v0.14.1...barretenberg-v0.14.2) (2023-11-07) ### Features * Run solidity tests for all acir artifacts ([#3161](#3161)) ([d09f667](d09f667)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release *beep* *boop* --- <details><summary>aztec-packages: 0.14.2</summary> ## [0.14.2](AztecProtocol/aztec-packages@aztec-packages-v0.14.1...aztec-packages-v0.14.2) (2023-11-07) ### Features * Load private tests and docs ([#3243](AztecProtocol/aztec-packages#3243)) ([f3d8aae](AztecProtocol/aztec-packages@f3d8aae)), closes [#1285](AztecProtocol/aztec-packages#1285) * Run solidity tests for all acir artifacts ([#3161](AztecProtocol/aztec-packages#3161)) ([d09f667](AztecProtocol/aztec-packages@d09f667)) ### Bug Fixes * Wait for accounts to catch up with notes when deployed ([#2834](AztecProtocol/aztec-packages#2834)) ([a8f3119](AztecProtocol/aztec-packages@a8f3119)) ### Miscellaneous * Add noir-protocol-circuits to deploy_npm ([#3268](AztecProtocol/aztec-packages#3268)) ([1a22cae](AztecProtocol/aztec-packages@1a22cae)) * Aztec-cli better volume mounting strategy ([#3138](AztecProtocol/aztec-packages#3138)) ([d40460e](AztecProtocol/aztec-packages@d40460e)) * Disable circuits tasks ([#3253](AztecProtocol/aztec-packages#3253)) ([e8945f8](AztecProtocol/aztec-packages@e8945f8)) </details> <details><summary>barretenberg.js: 0.14.2</summary> ## [0.14.2](AztecProtocol/aztec-packages@barretenberg.js-v0.14.1...barretenberg.js-v0.14.2) (2023-11-07) ### Features * Run solidity tests for all acir artifacts ([#3161](AztecProtocol/aztec-packages#3161)) ([d09f667](AztecProtocol/aztec-packages@d09f667)) </details> <details><summary>barretenberg: 0.14.2</summary> ## [0.14.2](AztecProtocol/aztec-packages@barretenberg-v0.14.1...barretenberg-v0.14.2) (2023-11-07) ### Features * Run solidity tests for all acir artifacts ([#3161](AztecProtocol/aztec-packages#3161)) ([d09f667](AztecProtocol/aztec-packages@d09f667)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Please provide a paragraph or two giving a summary of the change, including relevant motivation and context.
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.