Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prune 0 values from L2Tx #3222

Closed
benesjan opened this issue Nov 3, 2023 · 0 comments · Fixed by #3224
Closed

Prune 0 values from L2Tx #3222

benesjan opened this issue Nov 3, 2023 · 0 comments · Fixed by #3224

Comments

@benesjan
Copy link
Contributor

benesjan commented Nov 3, 2023

Currently we include 0 values in L2Tx. That is the newNullifier, newCommitments etc. arrays are always the same size and are padded with 0 values.

This makes testing more annoying because checking the amount of new commitments etc. is quite common and it makes serialization inefficient.
@github-project-automation github-project-automation bot moved this to Todo in A3 Nov 3, 2023
@benesjan benesjan mentioned this issue Nov 3, 2023
Merged
4 tasks
benesjan added a commit that referenced this issue Nov 6, 2023
@benesjan
refactor: prune 0 values from L2Tx (#3224)
2de206d 
Fixes #3222
\+ included recompiled artifacts because they no longer contain absolute
path.
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: prune 0 values from L2Tx AztecProtocol/aztec-packages
1 participant
@benesjan