Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make our Note terminology consistent #2908

Closed
benesjan opened this issue Oct 18, 2023 · 0 comments · Fixed by #3051
Closed

Make our Note terminology consistent #2908

benesjan opened this issue Oct 18, 2023 · 0 comments · Fixed by #3051
Assignees
@benesjan

Comments

@benesjan
Copy link
Contributor

benesjan commented Oct 18, 2023 •
edited
Loading

Go through all the occurrences of “Note” word in our codebase and ensure that the naming is consistent. I think it makes sense to base the naming on the meaning of Note in Noir where it represents the actual note data (e.g. value, owner, randomness etc.) and not the note hash/note commitment in the note hash tree.
@github-project-automation github-project-automation bot moved this to Todo in A3 Oct 18, 2023
@benesjan benesjan changed the title Make our Note terminology consistent Make our Note terminology consistent Oct 18, 2023
@benesjan benesjan mentioned this issue Oct 26, 2023
Merged
4 tasks
benesjan added a commit that referenced this issue Oct 30, 2023
@benesjan
feat!: PXE.getNotes(...) + refactor of note types (#3051)
16abb5a 
Fixes #2908 
Fixes
[#2909](#2909)
Fixes
[#2910](#2910)
Fixes #3061 

**Note 1**: This PR became huge because it made sense to refactor
`PXE.addNotes` here as well since I now use the ExtendedNote type there.
**Note 2**: Since this PR is already too big I decided to finish
renaming preimage as serialized_note in Noir in a separate PR.
**Note 3**: Note processor now stores a `CompleteAddress` instead of
just a public key because I need the address from `CompleteAddress` to
construct the `ExtendedNote`.
**Note 4**: This is a breaking change because of the `PXE.getNotes`
change and the `PXE.getPrivateStorageAt` removal.
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Oct 30, 2023
@benesjan benesjan mentioned this issue Nov 15, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benesjan benesjan

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: PXE.getNotes(...) + refactor of note types AztecProtocol/aztec-packages
2 participants
@benesjan @rahul-kothari