Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add decimals and token name to token #2889

Closed
Tracked by #2888
LHerskind opened this issue Oct 17, 2023 · 0 comments · Fixed by #3862
Closed
Tracked by #2888

Add decimals and token name to token #2889

LHerskind opened this issue Oct 17, 2023 · 0 comments · Fixed by #3862
Assignees

Comments

@LHerskind
Copy link
Contributor

LHerskind commented Oct 17, 2023

The current token that we are using as our standard don't include decimals, symbol nor name as the ERC20 often see (some optional). These should be included as immutables in the contract and have getters such that it can easily be read both from private and public for better composability with DeFi contracts which might need to read these (decimals often used when matching precision between tokens etc).

@github-project-automation github-project-automation bot moved this to Todo in A3 Oct 17, 2023
@LHerskind LHerskind self-assigned this Jan 4, 2024
@LHerskind LHerskind moved this from Todo to In Progress in A3 Jan 8, 2024
@LHerskind LHerskind moved this from In Progress to In Review in A3 Jan 9, 2024
LHerskind added a commit that referenced this issue Jan 9, 2024
)

Fixes #2889 by adding support for str as input arg and adding a compressed string struct.
@github-project-automation github-project-automation bot moved this from In Review to Done in A3 Jan 9, 2024
michaelelliot pushed a commit to Swoir/noir_rs that referenced this issue Feb 28, 2024
…tecProtocol#3862)

Fixes AztecProtocol#2889 by adding support for str as input arg and adding a compressed string struct.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant