Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete SEARCH_START_BLOCK #2829

Closed
rahul-kothari opened this issue Oct 13, 2023 · 0 comments · Fixed by #2830
Closed

Delete SEARCH_START_BLOCK #2829

rahul-kothari opened this issue Oct 13, 2023 · 0 comments · Fixed by #2830
Assignees
@rahul-kothari

Comments

@rahul-kothari
Copy link
Contributor

Currently only used by the archiver during its creation. Archiver only begins syncing L1 blocks from this number. Very useful when a user wants to run Aztec against a forked mainnet.
The registry smart contract stores the block number a rollup contract was created. So the archiver can directly fetch this block number from the smart contract, instead of us passing this parameter around for realising this!

Good UX TOO since devs now don't need to set this param.

h/t Lasse for this idea!
@rahul-kothari rahul-kothari added this to A3 Oct 10, 2023
@rahul-kothari rahul-kothari converted this from a draft issue Oct 13, 2023
@rahul-kothari rahul-kothari self-assigned this Oct 13, 2023
@rahul-kothari rahul-kothari mentioned this issue Oct 13, 2023
Merged
rahul-kothari added a commit that referenced this issue Oct 13, 2023
@rahul-kothari
feat(archiver): use registry to fetch searchStartBlock (#2830)
e5bc067 
Fix #2829 - remove searchStartBlock env var by using registry to fetch
current block number
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Oct 13, 2023
@Maddiaa0 Maddiaa0 removed this from A3 Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rahul-kothari rahul-kothari

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(archiver): use registry to fetch searchStartBlock AztecProtocol/aztec-packages
1 participant
@rahul-kothari