Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Clarify Map section of Storage page #2662

Closed
Tracked by #2658
critesjosh opened this issue Oct 3, 2023 · 0 comments · Fixed by #3212
Closed
Tracked by #2658

Docs: Clarify Map section of Storage page #2662

critesjosh opened this issue Oct 3, 2023 · 0 comments · Fixed by #3212
Labels
A-documentation Area: relates to documentation T-feedback Type: recording user feedback

Comments

@critesjosh
Copy link
Contributor

The docs on this page are confusing: https://docs.aztec.network/dev_docs/contracts/syntax/storage

Make it clear that a Map can be used with public and private state.
@critesjosh critesjosh added A-documentation Area: relates to documentation T-feedback Type: recording user feedback labels Oct 3, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Oct 3, 2023
@critesjosh critesjosh mentioned this issue Oct 3, 2023
Closed
@critesjosh critesjosh mentioned this issue Nov 2, 2023
Merged
4 tasks
critesjosh added a commit that referenced this issue Nov 3, 2023
@critesjosh
docs: Update storage doc (#3212)
d707d4e 
This PR removes the implementation references in the Storage and Authwit
pages, removes some unnecessary text and adds some examples.

closes #2662
closes #3209

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [x] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [x] Every change is related to the PR description.
- [x] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-documentation Area: relates to documentation T-feedback Type: recording user feedback
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs: Update storage doc AztecProtocol/aztec-packages
1 participant
@critesjosh