Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: getInitialWitness should not roll its own #2625

Closed
LHerskind opened this issue Oct 2, 2023 · 0 comments · Fixed by #2713
Closed

refactor: getInitialWitness should not roll its own #2625

LHerskind opened this issue Oct 2, 2023 · 0 comments · Fixed by #2713
Assignees
@LHerskind
Labels
T-refactor Type: this code needs refactoring

Comments

@LHerskind
Copy link
Contributor

Use the serialize and deserialize functions defined when computing the getInitialWitness functions instead of handrolling.

Currently both the private and public initial witnesses are handrolled due to tech debt, so after updating serialize and deserialize you need to update in here as well make sure it have an effect.
@github-project-automation github-project-automation bot moved this to Todo in A3 Oct 2, 2023
@LHerskind LHerskind added the T-refactor Type: this code needs refactoring label Oct 2, 2023
@LHerskind LHerskind self-assigned this Oct 5, 2023
@LHerskind LHerskind mentioned this issue Oct 5, 2023
Merged
4 tasks
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Oct 5, 2023
LHerskind added a commit that referenced this issue Oct 5, 2023
@LHerskind
refactor: Use serialize functions in getInitialWitness (#2713)
93cc668 
Fixes #2625. Using the functions defined in `serialize` when applicable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LHerskind LHerskind

Labels
T-refactor Type: this code needs refactoring
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Use serialize functions in getInitialWitness AztecProtocol/aztec-packages
1 participant
@LHerskind