Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanity check all user inputs in aztec-cli #2508

Closed
PhilWindle opened this issue Sep 25, 2023 · 0 comments · Fixed by #2571
Closed

Sanity check all user inputs in aztec-cli #2508

PhilWindle opened this issue Sep 25, 2023 · 0 comments · Fixed by #2571
Assignees
@alexghr

Comments

@PhilWindle
Copy link
Collaborator

PhilWindle commented Sep 25, 2023 •
edited
Loading

Many aztec-cli commands have inputs that must adhere to a known format (e.g. private keys, addresses). All of these inputs should have a sanity check performed on them at runtime.
@PhilWindle PhilWindle added this to A3 Sep 25, 2023
@PhilWindle PhilWindle converted this from a draft issue Sep 25, 2023
@benesjan benesjan self-assigned this Sep 26, 2023
@benesjan benesjan moved this from Todo to In Progress in A3 Sep 26, 2023
@benesjan benesjan assigned alexghr and unassigned benesjan Sep 26, 2023
@benesjan benesjan moved this from In Progress to Todo in A3 Sep 26, 2023
@alexghr alexghr mentioned this issue Sep 28, 2023
Merged
4 tasks
@alexghr alexghr moved this from Todo to In Review in A3 Sep 28, 2023
PhilWindle pushed a commit that referenced this issue Sep 28, 2023
@alexghr
fix: cli type check arguments and options (#2571)
ecffc36 
This PR adds type checking to CLI parameters.
 
Fix #2508 

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [x] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [x] Every change is related to the PR description.
- [x] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).
@github-project-automation github-project-automation bot moved this from In Review to Done in A3 Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexghr alexghr

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: cli type check arguments and options AztecProtocol/aztec-packages
3 participants
@alexghr @benesjan @PhilWindle