Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI failure notifications are not being sent from e2e jobs #249

Closed
spalladino opened this issue Apr 12, 2023 · 1 comment
Closed

CI failure notifications are not being sent from e2e jobs #249

spalladino opened this issue Apr 12, 2023 · 1 comment
Assignees
@spalladino
Labels
A-devops Area: Devops. E.g. CI / build systems T-bug Type: Bug. Something is broken.

Comments

@spalladino
Copy link
Collaborator

We are using the Slack orb, which requires curl, which is not installed in the aztecprotocol/alpine-build-image we use for our e2e tests.
@spalladino spalladino added T-bug Type: Bug. Something is broken. A-devops Area: Devops. E.g. CI / build systems labels Apr 12, 2023
@spalladino spalladino added this to A3 Apr 12, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Apr 12, 2023
@spalladino spalladino moved this from Todo to In Progress in A3 Apr 12, 2023
@spalladino spalladino self-assigned this Apr 12, 2023
@spalladino spalladino mentioned this issue Apr 12, 2023
Merged
@spalladino
Copy link
Collaborator Author

Fixed via AztecProtocol/build-system#4

@github-project-automation github-project-automation bot moved this from In Progress to Done in A3 Apr 12, 2023
ludamad pushed a commit that referenced this issue Apr 14, 2023
@Maddiaa0
fix: nullifier tests (#249)
f1dc5d3 
* fixes

* fix: more possible regression tests

* fix: remove logs

* fix: remove more logs

* clean: reuse test code

* clean

* rm done todo

---------

Co-authored-by: cheethas <[email protected]>
ludamad pushed a commit that referenced this issue Apr 17, 2023
@Maddiaa0 @ludamad
fix: nullifier tests (#249)
f7c09de 
* fixes

* fix: more possible regression tests

* fix: remove logs

* fix: remove more logs

* clean: reuse test code

* clean

* rm done todo

---------

Co-authored-by: cheethas <[email protected]>
ludamad pushed a commit that referenced this issue Apr 17, 2023
@Maddiaa0 @ludamad
fix: nullifier tests (#249)
65fd998 
* fixes

* fix: more possible regression tests

* fix: remove logs

* fix: remove more logs

* clean: reuse test code

* clean

* rm done todo

---------

Co-authored-by: cheethas <[email protected]>
@iAmMichaelConnor iAmMichaelConnor removed this from A3 Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spalladino spalladino

Labels
A-devops Area: Devops. E.g. CI / build systems T-bug Type: Bug. Something is broken.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@spalladino