Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON RPC encoder doesn't convert zero bigints correctly #2402

Closed
sirasistant opened this issue Sep 19, 2023 · 0 comments · Fixed by #2403 or #2401
Closed

JSON RPC encoder doesn't convert zero bigints correctly #2402

sirasistant opened this issue Sep 19, 2023 · 0 comments · Fixed by #2403 or #2401
Assignees
@sirasistant

Comments

@sirasistant
Copy link
Collaborator

0n is converted to a string representation, instead of handled like any non-zero bigint.
This causes that methods that send a zero bigint (such as a view function with a numerical param) fail to be called.
@sirasistant sirasistant self-assigned this Sep 19, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Sep 19, 2023
@sirasistant sirasistant mentioned this issue Sep 19, 2023
Merged
sirasistant added a commit that referenced this issue Sep 19, 2023
@sirasistant
fix: Handle falsy bigints in json-rpc (#2403)
d100650 
Resolves #2402
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Sep 19, 2023
@AztecBot AztecBot mentioned this issue Sep 19, 2023
Merged
PhilWindle pushed a commit that referenced this issue Sep 20, 2023
@AztecBot
chore(master): Release 0.7.10 (#2401)
e4b559e 
🤖 I have created a release *beep* *boop*
---


<details><summary>aztec-packages: 0.7.10</summary>

##
[0.7.10](aztec-packages-v0.7.9...aztec-packages-v0.7.10)
(2023-09-20)


### Features

* Aztec-cli unbox "really empty box"
([#2388](#2388))
([b57182d](b57182d))
* **docs:** Document noir macros
([#2016](#2016))
([1f1a17f](1f1a17f))
* **docs:** Include aztec rpc interface typedoc output in docs
([#2255](#2255))
([62c9e9b](62c9e9b))
* **token portal standard:** Create a token portal standard
([#2351](#2351))
([426a3ea](426a3ea))


### Bug Fixes

* **build:** Fix build system post deployment tests
([#2420](#2420))
([d509dc3](d509dc3))
* CLI encoding for arrays and structs
([#2407](#2407))
([85283bd](85283bd))
* Correct sandbox addresses in up-quick-start test
([#2412](#2412))
([974d859](974d859))
* **docs:** Revert include aztec rpc interface typedoc output in docs
([#2255](#2255))
([f852432](f852432))
* Handle falsy bigints in json-rpc
([#2403](#2403))
([d100650](d100650)),
closes
[#2402](#2402)
* **nargo_check.sh:** UNIX standard grep
([#2396](#2396))
([02e788a](02e788a))


### Miscellaneous

* **docs:** Note getter options
([#2411](#2411))
([8a95d8c](8a95d8c))
* Update docs url in config
([#2386](#2386))
([e44066d](e44066d))
</details>

<details><summary>barretenberg.js: 0.7.10</summary>

##
[0.7.10](barretenberg.js-v0.7.9...barretenberg.js-v0.7.10)
(2023-09-20)


### Miscellaneous

* **barretenberg.js:** Synchronize aztec-packages versions
</details>

<details><summary>barretenberg: 0.7.10</summary>

##
[0.7.10](barretenberg-v0.7.9...barretenberg-v0.7.10)
(2023-09-20)


### Miscellaneous

* **barretenberg:** Synchronize aztec-packages versions
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sirasistant sirasistant

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
1 participant
@sirasistant