-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change http-node to use JSON RPC #2358
Comments
alexghr
added a commit
that referenced
this issue
Sep 22, 2023
This PR replaces the HTTP rest API exposed by `rollup-provider` with a JSON-RPC server for `AztecNode`. ATM the `@aztec/aztec-node` package exports both the server and client implementation but it might make sense to move the JSON-RPC client to its own package. Along the way I had to update some of the models to make them serialisable to/from strings. I have added tests as needed. I have also removed `rollup-provider` since that seemed to no longer used and it was a just thin wrapper around an `AztecNode` and its REST API. See also #2358 # Checklist: Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge. - [ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag. - [x] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code. - [x] Every change is related to the PR description. - [x] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to relevant issues (if any exist).
Fixed in #2444 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: