Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete generic wasm functions #231

Closed
PhilWindle opened this issue Apr 11, 2023 · 3 comments
Closed

Complete generic wasm functions #231

PhilWindle opened this issue Apr 11, 2023 · 3 comments
Assignees
@spypsy

Comments

@PhilWindle
Copy link
Collaborator

No description provided.

@PhilWindle PhilWindle added this to A3 Apr 11, 2023
@PhilWindle PhilWindle converted this from a draft issue Apr 11, 2023
@PhilWindle PhilWindle assigned PhilWindle and unassigned PhilWindle Apr 11, 2023
@PhilWindle
Copy link
Collaborator Author

I created some a couple of generic functions in abis.ts. One of these is working and is being used, the other is commented out. It would be great to get the commented out function working.

@spypsy spypsy moved this from Todo to In Progress in A3 Apr 11, 2023
@spypsy spypsy moved this from In Progress to Todo in A3 Apr 12, 2023
ludamad pushed a commit that referenced this issue Apr 14, 2023
@Maddiaa0
fix: Nullifier tree bug (#231)
9b64d57 
* fix: small nullifier tree issue

* clean

* fix: add negative test

* revert hash_pair -> hash_multiple change

* add new cmake instruction (issue #236) - point to suyashes pedersen branch

---------

Co-authored-by: cheethas <[email protected]>
@spypsy spypsy moved this from Todo to In Progress in A3 Apr 17, 2023
@spypsy spypsy moved this from In Progress to In Review in A3 Apr 17, 2023
@spypsy spypsy mentioned this issue Apr 17, 2023
Merged
6 tasks
@spypsy
Copy link
Member

spypsy commented Apr 17, 2023

#279

ludamad pushed a commit that referenced this issue Apr 17, 2023
@Maddiaa0 @ludamad
fix: Nullifier tree bug (#231)
9079a03 
* fix: small nullifier tree issue

* clean

* fix: add negative test

* revert hash_pair -> hash_multiple change

* add new cmake instruction (issue #236) - point to suyashes pedersen branch

---------

Co-authored-by: cheethas <[email protected]>
ludamad pushed a commit that referenced this issue Apr 17, 2023
@Maddiaa0 @ludamad
fix: Nullifier tree bug (#231)
5019568 
* fix: small nullifier tree issue

* clean

* fix: add negative test

* revert hash_pair -> hash_multiple change

* add new cmake instruction (issue #236) - point to suyashes pedersen branch

---------

Co-authored-by: cheethas <[email protected]>
@spypsy spypsy moved this from In Review to Done in A3 Apr 18, 2023
@iAmMichaelConnor
Copy link
Contributor

Closing because moved to 'Done'

@iAmMichaelConnor iAmMichaelConnor removed this from A3 Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spypsy spypsy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@spypsy @iAmMichaelConnor @PhilWindle