Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile noir-contracts with nargo compile #2258

Closed
iAmMichaelConnor opened this issue Sep 12, 2023 · 2 comments
Closed

Compile noir-contracts with nargo compile #2258

iAmMichaelConnor opened this issue Sep 12, 2023 · 2 comments
Assignees
Labels
A-devops Area: Devops. E.g. CI / build systems C-aztec.nr Component: Aztec smart contract framework

Comments

@iAmMichaelConnor
Copy link
Contributor

noir-contracts currently takes silly amounts of ram to compile due to spinning up so many copies of bb at once. I'd recommend switching the shell scripts to just run nargo compile once noir-lang/noir#2612 lands as compilation just takes ~8 seconds on my machine whereas yarn noir:build:all just ends up crashing.

Originally posted by @TomAFrench in #2083 (comment)

@github-project-automation github-project-automation bot moved this to Todo in A3 Sep 12, 2023
@iAmMichaelConnor iAmMichaelConnor added C-aztec.nr Component: Aztec smart contract framework A-devops Area: Devops. E.g. CI / build systems labels Sep 12, 2023
@TomAFrench
Copy link
Member

This will also remove the need for install_noir_backend.sh (and along with it the need to keep the download URL up to date) as we won't have N different versions of nargo all trying to download bb to the same directory.

One downside is that you won't be able to compile arbitrary subsets of contracts in parallel, it'll be all of them or a single contract, but I don't imagine that would be a dealbreaker.

@Maddiaa0 Maddiaa0 self-assigned this Sep 13, 2023
@Maddiaa0
Copy link
Member

Will pick this up now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Devops. E.g. CI / build systems C-aztec.nr Component: Aztec smart contract framework
Projects
Archived in project
Development

No branches or pull requests

3 participants