Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Different salts result in the same contract address #2090

Closed
iAmMichaelConnor opened this issue Sep 7, 2023 · 0 comments · Fixed by #2467
Closed

Different salts result in the same contract address #2090

iAmMichaelConnor opened this issue Sep 7, 2023 · 0 comments · Fixed by #2467
Assignees
@alexghr
Labels
T-bug Type: Bug. Something is broken.

Comments

@iAmMichaelConnor
Copy link
Contributor

A bug reported by a sandbox user.

Apparently a salt of 0 and 1 results in the same contract address.

  • Validate that this is the case
  • Understand why this is the case
  • Resolve the issue
  • Add a regression test
@iAmMichaelConnor iAmMichaelConnor added the T-bug Type: Bug. Something is broken. label Sep 7, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Sep 7, 2023
@alexghr alexghr self-assigned this Sep 21, 2023
@alexghr alexghr moved this from Todo to In Progress in A3 Sep 21, 2023
@alexghr alexghr mentioned this issue Sep 22, 2023
Merged
4 tasks
@alexghr alexghr moved this from In Progress to In Review in A3 Sep 22, 2023
PhilWindle pushed a commit that referenced this issue Sep 25, 2023
@alexghr
fix: loading salt into buffer in the cli (#2467)
753ac49 
This PR is fixes #2090. The `--salt` option will now be checked to be a
valid hex string before being loaded into a `Buffer`.

The cli will now reject salts containing invalid characters (outside of
`[0-9a-f]`) and in case a in case a string with an add number of
characters is passed then it will be left padded with a zero in order to
for it to be loaded into a Buffer.

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [x] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [x] Every change is related to the PR description.
- [x] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).
@github-project-automation github-project-automation bot moved this from In Review to Done in A3 Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexghr alexghr

Labels
T-bug Type: Bug. Something is broken.
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: loading salt into buffer in the cli AztecProtocol/aztec-packages
2 participants
@alexghr @iAmMichaelConnor