Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove dead code from c_bind of private kernel circuit #2087

Closed
Tracked by #738
jeanmon opened this issue Sep 7, 2023 · 1 comment · Fixed by #2088
Closed
Tracked by #738

chore: remove dead code from c_bind of private kernel circuit #2087

jeanmon opened this issue Sep 7, 2023 · 1 comment · Fixed by #2088
Assignees
@jeanmon
Labels
C-protocol-circuits Component: Protocol circuits (kernel & rollup) T-refactor Type: this code needs refactoring

Comments

@jeanmon
Copy link
Contributor

jeanmon commented Sep 7, 2023

No description provided.

@github-project-automation github-project-automation bot moved this to Todo in A3 Sep 7, 2023
@jeanmon jeanmon mentioned this issue Sep 7, 2023
Closed
@jeanmon jeanmon self-assigned this Sep 7, 2023
@jeanmon
Copy link
Contributor Author

jeanmon commented Sep 7, 2023

The following functions are not used and will probably be completely rewritten when we start to write real circuits:

  • private_kernel__init_proving_key
  • private_kernel__init_verification_key
  • private_kernel__prove
  • private_kernel__verify_proof

@jeanmon jeanmon added C-protocol-circuits Component: Protocol circuits (kernel & rollup) T-refactor Type: this code needs refactoring labels Sep 7, 2023
@jeanmon jeanmon mentioned this issue Sep 7, 2023
Merged
4 tasks
@jeanmon jeanmon moved this from Todo to In Progress in A3 Sep 7, 2023
@jeanmon jeanmon moved this from In Progress to In Review in A3 Sep 7, 2023
jeanmon added a commit that referenced this issue Sep 7, 2023
@jeanmon
chore(circuits): - remove dead code from cbind of private kernel circ…
43dc9d7 
…uit (#2088)

Resolves #2087 

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [x] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [x] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [x] Every change is related to the PR description.
- [x] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).
@github-project-automation github-project-automation bot moved this from In Review to Done in A3 Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeanmon jeanmon

Labels
C-protocol-circuits Component: Protocol circuits (kernel & rollup) T-refactor Type: this code needs refactoring
Projects
A3
Archived in project
Milestone
No milestone
1 participant
@jeanmon