Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bb should expose a command to query the language being used. #1923

Closed
TomAFrench opened this issue Aug 31, 2023 · 0 comments · Fixed by #2010
Closed

bb should expose a command to query the language being used. #1923

TomAFrench opened this issue Aug 31, 2023 · 0 comments · Fixed by #2010
Labels
C-bb.js Component: bb.js - wrapping bberg in js

Comments

@TomAFrench
Copy link
Member

ACVM needs to know the language being used by the backend in order to tailor the ACIR to it.

https://github.com/noir-lang/acvm/blob/cfd8cbf58307511ac0cc9106c299695c2ca779de/acvm/src/compiler/mod.rs#L111-L126

bb then needs to be able to communicate this to Nargo.
@github-project-automation github-project-automation bot moved this to Todo in A3 Aug 31, 2023
@TomAFrench TomAFrench added this to Noir Sep 1, 2023
@TomAFrench TomAFrench self-assigned this Sep 1, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Sep 1, 2023
@TomAFrench TomAFrench removed their assignment Sep 1, 2023
@TomAFrench TomAFrench added the C-bb.js Component: bb.js - wrapping bberg in js label Sep 4, 2023
@TomAFrench TomAFrench mentioned this issue Sep 5, 2023
Merged
5 tasks
@kevaundray kevaundray mentioned this issue Sep 5, 2023
Merged
4 tasks
kevaundray added a commit that referenced this issue Sep 5, 2023
@kevaundray @TomAFrench
feat: Add info command to bb (#2010)
1fd8196 
Resolves #1922 
Resolves #1923 

# Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if
the PR is ready to merge.
- [ ] If the pull request requires a cryptography review (e.g.
cryptographic algorithm implementations) I have added the 'crypto' tag.
- [ ] I have reviewed my diff in github, line by line and removed
unexpected formatting changes, testing logs, or commented-out code.
- [ ] Every change is related to the PR description.
- [ ] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to relevant issues (if any exist).

---------

Co-authored-by: Tom French <[email protected]>
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Sep 5, 2023
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Sep 5, 2023
codygunton pushed a commit that referenced this issue Jan 23, 2024
@PhilWindle
Merge pull request #1923 from AztecProtocol/defi-bridge-project
a2a382f 
Revert "Revert "Verification Key changes (#1695)""
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bb.js Component: bb.js - wrapping bberg in js
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add info command to bb AztecProtocol/aztec-packages
1 participant
@TomAFrench