fix: Reset keccak var inputs to 0 #1881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guipublic
changed the title
PhilWindle
pushed a commit
that referenced
this pull request
Aug 30, 2023
🤖 I have created a new Aztec Packages release --- ## [0.1.0-alpha49](v0.1.0-alpha48...v0.1.0-alpha49) (2023-08-30) ### Features * Generate public context contract interfaces ([#1860](#1860)) ([2f4045e](2f4045e)), closes [#1782](#1782) ### Bug Fixes * Do not warn on mismatched cli/sandbox version ([#1894](#1894)) ([a44a0f6](a44a0f6)) * remove extra transfer arg in CLI Guide ([#1887](#1887)) ([55728b8](55728b8)) * Reset keccak var inputs to 0 ([#1881](#1881)) ([382f07e](382f07e)) ### Miscellaneous * **1074:** remove read request data from final private kernel circuit public inputs ([#1840](#1840)) ([c61557a](c61557a)) * Reenable and refactor nested calls e2e tests ([#1868](#1868)) ([570de80](570de80)), closes [#1587](#1587) * Update formatting ([#1874](#1874)) ([fb973ca](fb973ca)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes noir issue 1934 (noir-lang/noir#1934):
When using variable size keccak, the inputs that are after the provided length where not set to 0.
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.