Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repair/Re-enable three skipped tests in e2e_nested_contract.test.ts #1587

Closed
jeanmon opened this issue Aug 16, 2023 · 0 comments · Fixed by #1868 or #1882
Closed

Repair/Re-enable three skipped tests in e2e_nested_contract.test.ts #1587

jeanmon opened this issue Aug 16, 2023 · 0 comments · Fixed by #1868 or #1882
Assignees
@spalladino
Labels
T-testing Type: Testing. More tests need to be added.

Comments

@jeanmon
Copy link
Contributor

jeanmon commented Aug 16, 2023

The 'parent manually calls child' test suite with 3 following cases failing/skipped:
'enqueues multiple public calls', 'enqueues multiple public calls with nested public calls', 'reads fresh value after write within the same tx'
@jeanmon jeanmon added the T-testing Type: Testing. More tests need to be added. label Aug 16, 2023
@jeanmon jeanmon added this to A3 Aug 16, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Aug 16, 2023
@jeanmon jeanmon mentioned this issue Aug 16, 2023
Closed
@iAmMichaelConnor iAmMichaelConnor added this to the 📢 Initial Public Sandbox Release milestone Aug 25, 2023
@spalladino spalladino self-assigned this Aug 29, 2023
@spalladino spalladino mentioned this issue Aug 29, 2023
Merged
@spalladino spalladino moved this from Todo to In Review in A3 Aug 29, 2023
spalladino added a commit that referenced this issue Aug 30, 2023
@spalladino
chore: Reenable and refactor nested calls e2e tests (#1868)
570de80 
Fixes #1587
@github-project-automation github-project-automation bot moved this from In Review to Done in A3 Aug 30, 2023
@github-actions github-actions bot mentioned this issue Aug 30, 2023
Merged
PhilWindle pushed a commit that referenced this issue Aug 30, 2023
@github-actions
chore(master): release 0.1.0-alpha49 (#1882)
685e3a9 
🤖 I have created a new Aztec Packages release
---


##
[0.1.0-alpha49](v0.1.0-alpha48...v0.1.0-alpha49)
(2023-08-30)


### Features

* Generate public context contract interfaces
([#1860](#1860))
([2f4045e](2f4045e)),
closes
[#1782](#1782)


### Bug Fixes

* Do not warn on mismatched cli/sandbox version
([#1894](#1894))
([a44a0f6](a44a0f6))
* remove extra transfer arg in CLI Guide
([#1887](#1887))
([55728b8](55728b8))
* Reset keccak var inputs to 0
([#1881](#1881))
([382f07e](382f07e))


### Miscellaneous

* **1074:** remove read request data from final private kernel circuit
public inputs
([#1840](#1840))
([c61557a](c61557a))
* Reenable and refactor nested calls e2e tests
([#1868](#1868))
([570de80](570de80)),
closes
[#1587](#1587)
* Update formatting
([#1874](#1874))
([fb973ca](fb973ca))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spalladino spalladino

Labels
T-testing Type: Testing. More tests need to be added.
Projects
A3
Archived in project
Milestone
No milestone
3 participants
@spalladino @iAmMichaelConnor @jeanmon