-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: rename or cleanup makeEmpty functions in TS factories #1865
Comments
4 tasks
jeanmon
added a commit
that referenced
this issue
Aug 30, 2023
…it public inputs (#1840) Resolves #1074 Refactor task consisting in defining a specific struct for the public inputs of final ordering private kernel circuit. This new struct is named: KernelCircuitPublicInputsFinal This struct is identical to KernelCircuitPublicInputs except that we trimmed the 4 following members from CombinedAccumulatedData (a struct named FinalAccumulatedData was introduced for this purpose): - read_requests - read_request_membership_witnesses - public_data_update_requests - public_data_reads In addition, one commit which resolves #1865 was added. # Checklist: Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge. - [x] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag. - [x] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code. - [x] Every change is related to the PR description. - [x] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to relevant issues (if any exist).
codygunton
pushed a commit
that referenced
this issue
Jan 23, 2024
* Change logs back and disable defi-bridge-project filter * Switch filtering back to defi-bridge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
No description provided.
The text was updated successfully, but these errors were encountered: