Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Generate public context contract interfaces #1860

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

spalladino
Copy link
Collaborator

Generates two interface structs for each contract Foo: a FooPrivateContextInterface and a FooPublicContextInterface. The former is exactly as the one we had already, while the latter only contains public methods and uses public contexts instead of private ones.

Fixes #1782

@spalladino spalladino enabled auto-merge (squash) August 29, 2023 13:24
@spalladino spalladino requested a review from LHerskind August 29, 2023 13:25
Copy link
Contributor

@benesjan benesjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@spalladino spalladino force-pushed the palla/codegen-pub-interfaces branch from ad8801a to 875987a Compare August 30, 2023 12:45
@spalladino spalladino merged commit 2f4045e into master Aug 30, 2023
@spalladino spalladino deleted the palla/codegen-pub-interfaces branch August 30, 2023 12:59
PhilWindle pushed a commit that referenced this pull request Aug 30, 2023
🤖 I have created a new Aztec Packages release
---


##
[0.1.0-alpha49](v0.1.0-alpha48...v0.1.0-alpha49)
(2023-08-30)


### Features

* Generate public context contract interfaces
([#1860](#1860))
([2f4045e](2f4045e)),
closes
[#1782](#1782)


### Bug Fixes

* Do not warn on mismatched cli/sandbox version
([#1894](#1894))
([a44a0f6](a44a0f6))
* remove extra transfer arg in CLI Guide
([#1887](#1887))
([55728b8](55728b8))
* Reset keccak var inputs to 0
([#1881](#1881))
([382f07e](382f07e))


### Miscellaneous

* **1074:** remove read request data from final private kernel circuit
public inputs
([#1840](#1840))
([c61557a](c61557a))
* Reenable and refactor nested calls e2e tests
([#1868](#1868))
([570de80](570de80)),
closes
[#1587](#1587)
* Update formatting
([#1874](#1874))
([fb973ca](fb973ca))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@iAmMichaelConnor iAmMichaelConnor mentioned this pull request Sep 14, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Noir Contract Interfaces: generate 'callable from private' and 'callable from public' interfaces
2 participants