Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show call stacks for failing constraints in all functions #1815

Closed
Tracked by #1224
sirasistant opened this issue Aug 25, 2023 · 1 comment · Fixed by #1997
Closed
Tracked by #1224

Show call stacks for failing constraints in all functions #1815

sirasistant opened this issue Aug 25, 2023 · 1 comment · Fixed by #1997
Assignees
@sirasistant

Comments

@sirasistant
Copy link
Contributor

sirasistant commented Aug 25, 2023 •
edited
Loading

Currently, when an assertion is not met we print a call stack that is resolved at compile time. Since constrained functions are completely inlined, this callstack is complete for constrained functions, but unconstrained functions are not inlined during compilation to allow for recursion.

This makes the callstacks for unconstrained functions incomplete, since we need runtime information of the callstack when an opcode fails.

We'll have to modify the ACVM to report on brillig execution errors not a singular OpcodeLocation, but a vector of OpcodeLocations representing the [...callStack, failingConstraint].

We'll have to adapt the code in acir-simulator to create a complete CallStack with this list of opcode locations.
@sirasistant sirasistant mentioned this issue Aug 25, 2023
Closed
@github-project-automation github-project-automation bot moved this to Todo in A3 Aug 25, 2023
@sirasistant sirasistant self-assigned this Aug 25, 2023
@sirasistant
Copy link
Contributor Author

Corresponding noir issue noir-lang/noir#2550

@sirasistant sirasistant mentioned this issue Sep 5, 2023
Merged
4 tasks
sirasistant added a commit that referenced this issue Sep 5, 2023
@sirasistant
feat: Add support for assert messages & runtime call stacks (#1997)
ac68837 
Resolves #1814
Resolves #1815
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Sep 5, 2023
superstar0402 added a commit to superstar0402/aztec-nr that referenced this issue Aug 16, 2024
@superstar0402
feat: Add support for assert messages & runtime call stacks (#1997)
b9d1454 
Resolves AztecProtocol/aztec-packages#1814
Resolves AztecProtocol/aztec-packages#1815
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sirasistant sirasistant

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add support for assert messages & runtime call stacks AztecProtocol/aztec-packages
1 participant
@sirasistant