Temporarily remove automatic update to AztecProtocol/dev-bb.js
#1711
Labels
C-bb.js
Component: bb.js - wrapping bberg in js
Comments
4 tasks
|
Rerunning |
kevaundray
added a commit
that referenced
this issue
Aug 21, 2023
Related to #1711 # Checklist: Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge. - [ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag. - [ ] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code. - [ ] Every change is related to the PR description. - [ ] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to relevant issues (if any exist).
|
The action was re-ran with the AZTEC_GITHUB_TOKEN in barretenberg, and now it gives the following error: |
dan-aztec
added a commit
that referenced
this issue
Aug 22, 2023
fix colorscheme fix banner aztec logo prettier working? add api endpoint switch to cjs file parse contract functions, but no working form delete unneeded text comments slightly cleaner form slightly better css fix: Remove automatic update to `AztecProtocol/dev-bb.js` (#1712) Related to #1711 Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge. - [ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag. - [ ] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code. - [ ] Every change is related to the PR description. - [ ] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to relevant issues (if any exist). git subrepo push --branch=master circuits/cpp/barretenberg subrepo: subdir: "circuits/cpp/barretenberg" merged: "d883900f9" upstream: origin: "https://github.com/AztecProtocol/barretenberg" branch: "master" commit: "d883900f9" git-subrepo: version: "0.4.6" origin: "???" commit: "???" chore: sync bb master (#1713) Ran: ``` ./scripts/git_subrepo.sh pull circuits/cpp/barretenberg git checkout origin/master -- .gitmodules ``` Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge. - [ ] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag. - [ ] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code. - [ ] Every change is related to the PR description. - [ ] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to relevant issues (if any exist). copy the contract ABI into the new subdirectory fix output json name
|
Closing this as it seems we don't actually need dev-bb.js and it was a nice to have. We always upload to npm so functionaly its the same |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
The
secrets.AZTEC_BOT_GITHUB_TOKENthat is defined in the release-please.yml file works on aztec-packages but since this secret is not defined inAztecProtocol/barretenbergthis fails the release CI.Solution
Short term: we can remove this step in the release CI, so we can make releases. It is not being used anywhere as far as I know
Long term: we can add
AZTEC_BOT_GITHUB_TOKENas a organization level secret and give it access to all/selected repositories.The text was updated successfully, but these errors were encountered: