Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hack around bad UX for nullifying publicly-created notes #1655

Closed
Tracked by #1601
dbanks12 opened this issue Aug 18, 2023 · 1 comment · Fixed by #2230
Closed
Tracked by #1601

Hack around bad UX for nullifying publicly-created notes #1655

dbanks12 opened this issue Aug 18, 2023 · 1 comment · Fixed by #2230
Assignees
@dbanks12
Labels
A-ux/devex Area: relates to external ux / devex. (Users typically are devs) (See also A-internal-devex) C-aztec.nr Component: Aztec smart contract framework

Comments

@dbanks12
Copy link
Collaborator

dbanks12 commented Aug 18, 2023 •
edited
Loading

Can abstract this away by adding a set.remove_publicly_created() function and destroy_publicly_created_note. Is there a better way to make this UX not horrible?
@dbanks12 dbanks12 added this to A3 Aug 18, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Aug 18, 2023
@dbanks12 dbanks12 mentioned this issue Aug 18, 2023
Closed
@dbanks12 dbanks12 changed the title Hack around bad UX for nullifying public notes Hack around bad UX for nullifying publicly-created notes Aug 18, 2023
@iAmMichaelConnor iAmMichaelConnor added T-refactor Type: this code needs refactoring A-ux/devex Area: relates to external ux / devex. (Users typically are devs) (See also A-internal-devex) C-aztec.nr Component: Aztec smart contract framework labels Aug 20, 2023
@dbanks12 dbanks12 removed the T-refactor Type: this code needs refactoring label Aug 20, 2023
@iAmMichaelConnor iAmMichaelConnor modified the milestones: 🚀 Initial Aztec Sandbox Release, 📢 Initial Public Sandbox Release Aug 25, 2023
@dbanks12 dbanks12 self-assigned this Sep 5, 2023
@dbanks12
Copy link
Collaborator Author

dbanks12 commented Sep 6, 2023

Looks like this was resolved in this PR 5a54baf#diff-1a582424eaf0abe38e8c973e76a665066cb4823d2d2b1c52f4f04551e33970da

Should review the changes and make sure it is clear to the developer which library functions should be used when, and whether certain ones will be deprecated.

@dbanks12 dbanks12 mentioned this issue Sep 11, 2023
Merged
LeilaWang pushed a commit that referenced this issue Sep 12, 2023
@dbanks12
chore(noir-contracts): 1655 - rename functions to make hack clearer f…
707bc09 
…or publicly created notes (#2230)

Resolves #1655

`assert_contains_and_remove` has a hack that makes it only work for
publicly created note hashes. This PR renames the function to make it
clear that it only works for publicly created note hashes. It also
renames `assert_contains_note_and_remove` to
`assert_contains_and_remove` with a TODO to tweak it to only
`ensure_note_hash_exists` instead of `ensure_note_exists` once
`get_commitment` supports privately created commitments.
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbanks12 dbanks12

Labels
A-ux/devex Area: relates to external ux / devex. (Users typically are devs) (See also A-internal-devex) C-aztec.nr Component: Aztec smart contract framework
Projects
A3
Archived in project
Milestone
No milestone
2 participants
@iAmMichaelConnor @dbanks12