Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporary hack: overwrite private ordering kernel's final public_call_stack with simulator's output #1624

Closed
Tracked by #1601
dbanks12 opened this issue Aug 17, 2023 · 0 comments · Fixed by #1639
Closed
Tracked by #1601

Temporary hack: overwrite private ordering kernel's final public_call_stack with simulator's output #1624

dbanks12 opened this issue Aug 17, 2023 · 0 comments · Fixed by #1639
Assignees
@spalladino
Labels
C-protocol-circuits Component: Protocol circuits (kernel & rollup)
Milestone
🚀 Initial F&F San...

Comments

@dbanks12
Copy link
Collaborator

Do #1615 first
@dbanks12 dbanks12 added the C-protocol-circuits Component: Protocol circuits (kernel & rollup) label Aug 17, 2023
@dbanks12 dbanks12 added this to A3 Aug 17, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Aug 17, 2023
@dbanks12 dbanks12 mentioned this issue Aug 17, 2023
Closed
@spalladino spalladino mentioned this issue Aug 17, 2023
Merged
@spalladino spalladino self-assigned this Aug 18, 2023
spalladino added a commit that referenced this issue Aug 18, 2023
@spalladino
fix: Hack an ordering index for enqueued public calls (#1639)
87712e8 
Introduces an `order` field in `PublicCallRequest` (that is not sent to
cpp) which gets populated by the simulator, and used at the end to
reorder the enqueued public function calls and the public call stack.
The global order is kept by the simulator across nested calls, and
increased when each oracle call to enqueue a public function is hit.
This ordering can be reused for other side effects as well, and should
mimic the transition counters solution proposed
[here](https://discourse.aztec.network/t/identifying-the-ordering-of-state-access-across-contract-calls/382/12#transition-counters-for-private-calls-2).

Fixes #1624
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spalladino spalladino

Labels
C-protocol-circuits Component: Protocol circuits (kernel & rollup)
Projects
A3
Archived in project
Milestone
🚀 Initial F&F Sandbox Release
Development

Successfully merging a pull request may close this issue.

fix: Hack an ordering index for enqueued public calls AztecProtocol/aztec-packages
2 participants
@spalladino @dbanks12