Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporary hack: remove public kernel checks that state updates are in correct order #1622

Closed
Tracked by #1601
dbanks12 opened this issue Aug 17, 2023 · 1 comment · Fixed by #1685
Closed
Tracked by #1601

Temporary hack: remove public kernel checks that state updates are in correct order #1622

dbanks12 opened this issue Aug 17, 2023 · 1 comment · Fixed by #1685
Assignees
@dbanks12
Labels
C-protocol-circuits Component: Protocol circuits (kernel & rollup)
Milestone
🚀 Initial F&F San...

Comments

@dbanks12
Copy link
Collaborator

dbanks12 commented Aug 17, 2023 •
edited
Loading

Do #1616 (and maybe #1617) first

Followup: #1623
@dbanks12 dbanks12 added T-bug Type: Bug. Something is broken. C-protocol-circuits Component: Protocol circuits (kernel & rollup) labels Aug 17, 2023
@dbanks12 dbanks12 added this to A3 Aug 17, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Aug 17, 2023
This was referenced Aug 17, 2023
Closed
Closed
@dbanks12 dbanks12 removed the T-bug Type: Bug. Something is broken. label Aug 17, 2023
@dbanks12 dbanks12 mentioned this issue Aug 18, 2023
Merged
dbanks12 added a commit that referenced this issue Aug 18, 2023
@dbanks12
test: add tests that check ordering of public state updates (#1661)
5b9aedd 
Resolves #1616 

Added two tests:
* Setting public state value first directly, then again in a nested call
works, but
* Setting public state value first in a nested call, then directly
*fails*, but it shouldn't!
* Test commented out for now. Can be reenabled once public state
ordering is done or once we hack around this (#1622)
@dbanks12 dbanks12 moved this from Todo to In Progress in A3 Aug 20, 2023
@dbanks12 dbanks12 mentioned this issue Aug 21, 2023
Merged
@dbanks12
Copy link
Collaborator Author

Will be closed by #1685

suyash67 pushed a commit that referenced this issue Aug 21, 2023
@dbanks12
hack(ordering): public state action ordering (#1685)
4f02d09 
Resolves #1617
Resolves #1622 
Resolves #1623 

Patches the `PublicDataReads` and `PublicDataUpdateRequests` coming from
the public kernel to reorder them properly until public state is
properly reordered (#757).

---------
@github-project-automation github-project-automation bot moved this from In Progress to Done in A3 Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbanks12 dbanks12

Labels
C-protocol-circuits Component: Protocol circuits (kernel & rollup)
Projects
A3
Archived in project
Milestone
🚀 Initial F&F Sandbox Release
Development

Successfully merging a pull request may close this issue.

hack(ordering): public state action ordering AztecProtocol/aztec-packages
2 participants
@dbanks12 @jeanmon