Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update bootstrap compilation order #1398

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Conversation

Maddiaa0
Copy link
Member

@Maddiaa0 Maddiaa0 commented Aug 3, 2023

Eth and Aztec contracts are currently built before the update constants script runs, potentially leading to stale artifacts being compiled. This is currently not an issue as artifacts are commited, however i could forsee it becoming one.

Copy link
Contributor

@rahul-kothari rahul-kothari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excellent catch ser!

Copy link
Contributor

@benesjan benesjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rahul-kothari rahul-kothari merged commit c03a6fa into master Aug 3, 2023
@rahul-kothari rahul-kothari deleted the md/fix-bootstrap branch August 3, 2023 11:38
codygunton pushed a commit that referenced this pull request Jan 23, 2024
* Updated fork block (#1396)

* Updated fork block

* Set redeploy flag

* Redploy dev net (#1398)

* Force redeploy (#1399)

Co-authored-by: joss-aztec <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants