-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Noir Contracts: Can TransparentNote
of the non_native_token_contract
conform to the NoteInterface
?
#1363
Comments
It can, and I have started working on this here #1194 |
4 tasks
Closed as this is being done in #1194 |
Maddiaa0
pushed a commit
that referenced
this issue
Aug 7, 2023
Closes #1194 Closes #1363 Will likely rename getCommitment alongside all instances of "commitment" as a part of this other issue: #1408 # Checklist: Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge. - [x] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag. - [x] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code. - [x] Every change is related to the PR description. - [x] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to relevant issues (if any exist). --------- Co-authored-by: Michael Connor <[email protected]>
superstar0402
added a commit
to superstar0402/aztec-nr
that referenced
this issue
Aug 16, 2024
Closes AztecProtocol/aztec-packages#1194 Closes AztecProtocol/aztec-packages#1363 Will likely rename getCommitment alongside all instances of "commitment" as a part of this other issue: AztecProtocol/aztec-packages#1408 # Checklist: Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge. - [x] If the pull request requires a cryptography review (e.g. cryptographic algorithm implementations) I have added the 'crypto' tag. - [x] I have reviewed my diff in github, line by line and removed unexpected formatting changes, testing logs, or commented-out code. - [x] Every change is related to the PR description. - [x] I have [linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue) this pull request to relevant issues (if any exist). --------- Co-authored-by: Michael Connor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Ideally, we should be able to design every custom note to adhere to the
NoteInterface
:The motivation for this, is that an ordinary (not advanced) user can write notes without having to mention the Aztec
context
or theabi
. This is because theSet
,Singleton
andImmutableSingleton
types take care of pushing-to and pulling-from the context, abis, and trees, by wrapping custom notes.Currently, the
TransparentNote
deviates from this pattern. I don't fully understand the example, but would like to understand if the note could be made to conform to the pattern, or if there's something fundamental that's been overlooked in designing theNoteInterface
.Tagging @Maddiaa0 who I think designed this contract and note :)
The text was updated successfully, but these errors were encountered: