Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a method to SentTx to await for RPC server accounts to be fully synched #1340

Closed
spalladino opened this issue Aug 1, 2023 · 0 comments · Fixed by #1381
Closed

Add a method to SentTx to await for RPC server accounts to be fully synched #1340

spalladino opened this issue Aug 1, 2023 · 0 comments · Fixed by #1381
Assignees

Comments

@spalladino
Copy link
Collaborator

spalladino commented Aug 1, 2023

Currently user needs to send it, await it separately, check it’s been mined, and sometimes await for the rpc server to sync to avoid race conditions.

We recently introduced the wait() method that handles the awaiting and check that it’s mined, but we’re still missing the check for account synchronised.

We should add another method (or a flag to wait) to make it explicit that we want to wait until all accounts on the RPC server have been synchronised up to the block in which the tx was mined, in other words, its side effects are visible when querying the RPC server.

Note that waiting only on the accounts that were involved in the tx should be enough (ie accounts that sent or received notes), but doing this filtering is not easy since we lose that information when we get to a SentTx, so it's easier to just wait on all accounts to be synched.

@spalladino spalladino added this to A3 Aug 1, 2023
@spalladino spalladino converted this from a draft issue Aug 1, 2023
@spalladino spalladino moved this from Todo to In Progress in A3 Aug 2, 2023
@spalladino spalladino self-assigned this Aug 2, 2023
@spalladino spalladino moved this from In Progress to In Review in A3 Aug 2, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in A3 Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants