Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci, barretenberg] Reinstate bb-bin-test #1236

Closed
ludamad opened this issue Jul 27, 2023 · 1 comment · Fixed by #1326
Closed

[ci, barretenberg] Reinstate bb-bin-test #1236

ludamad opened this issue Jul 27, 2023 · 1 comment · Fixed by #1326

Comments

@ludamad
Copy link
Collaborator

ludamad commented Jul 27, 2023

It has been removed for now as it tests recursion which is not part of the new SSA + needs to be updated to the new serialization format
@github-project-automation github-project-automation bot moved this to Todo in A3 Jul 27, 2023
@ludamad ludamad mentioned this issue Jul 27, 2023
Merged
6 tasks
@TomAFrench
Copy link
Member

Note that as well as reenabling these in CI we need to commit new ACIR artifacts as were removed in #1235.

@vezenovm vezenovm mentioned this issue Jul 31, 2023
Merged
6 tasks
vezenovm added a commit that referenced this issue Aug 1, 2023
@vezenovm
chore(ci): Update build artifacts for recursion bin-test and enable b…
48aa541 
…in-test (#1326)

# Description

Resolves #1236 

The ACIR artifacts included in this PR are generated based off of this
work in the Noir repo: noir-lang/noir#2097. This
re-enables the CI now that recursive aggregation will be supported in
the new SSA.

This PR should only be merged though once the Noir PR that is linked
reaches master.

# Checklist:

- [X] I have reviewed my diff in github, line by line.
- [X] Every change is related to the PR description.
- [X] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to the issue(s) that it resolves.
- [X] There are no unexpected formatting changes, superfluous debug
logs, or commented-out code.
- [X] The branch has been merged or rebased against the head of its
merge target.
- [X] I'm happy for the PR to be merged at the reviewer's next
convenience.
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
2 participants
@ludamad @TomAFrench