Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw an error when requesting public storage for non-existent contract #1228

Closed
Tracked by #1115
benesjan opened this issue Jul 27, 2023 · 0 comments · Fixed by #1296
Closed
Tracked by #1115

Throw an error when requesting public storage for non-existent contract #1228

benesjan opened this issue Jul 27, 2023 · 0 comments · Fixed by #1296
Assignees
@benesjan

Comments

@benesjan
Copy link
Contributor

aztecRpcServer.getPublicStorageAt(contract, slot) doesn’t check if contract is in the contract tree. Throw an error if it's not the case.
@github-project-automation github-project-automation bot moved this to Todo in A3 Jul 27, 2023
@benesjan benesjan mentioned this issue Jul 27, 2023
Closed
@benesjan benesjan self-assigned this Jul 31, 2023
@benesjan benesjan mentioned this issue Jul 31, 2023
Merged
6 tasks
spalladino pushed a commit that referenced this issue Jul 31, 2023
@benesjan
feat: checking whether contract exists when getting storage (#1296)
7688457 
# Description

Fixes #1228 

# Checklist:

- [ ] I have reviewed my diff in github, line by line.
- [ ] Every change is related to the PR description.
- [ ] I have
[linked](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue)
this pull request to the issue(s) that it resolves.
- [ ] There are no unexpected formatting changes, superfluous debug
logs, or commented-out code.
- [ ] The branch has been merged or rebased against the head of its
merge target.
- [ ] I'm happy for the PR to be merged at the reviewer's next
convenience.
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benesjan benesjan

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: checking whether contract exists when getting storage AztecProtocol/aztec-packages
1 participant
@benesjan