Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add runtime check of input's validity to encoder #1227

Closed
Tracked by #1115
benesjan opened this issue Jul 27, 2023 · 0 comments · Fixed by #1246
Closed
Tracked by #1115

Add runtime check of input's validity to encoder #1227

benesjan opened this issue Jul 27, 2023 · 0 comments · Fixed by #1246
Assignees
@benesjan

Comments

@benesjan
Copy link
Contributor

Feeding garbage to function arguments results in:
cannot solve opcode: missing assignment for witness index 20

Example code:
image

Ensure that encoder throws a clear error when inputs are not valid.
@github-project-automation github-project-automation bot moved this to Todo in A3 Jul 27, 2023
@benesjan benesjan mentioned this issue Jul 27, 2023
Closed
@benesjan benesjan self-assigned this Jul 27, 2023
@benesjan benesjan moved this from Todo to In Progress in A3 Jul 27, 2023
@benesjan benesjan mentioned this issue Jul 27, 2023
Merged
6 tasks
@benesjan benesjan moved this from In Progress to In Review in A3 Jul 31, 2023
benesjan added a commit that referenced this issue Jul 31, 2023
@benesjan
feat: encoder runtime arguments check (#1246)
407b8b5 
# Description

Fixes #1227
@github-project-automation github-project-automation bot moved this from In Review to Done in A3 Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benesjan benesjan

Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: encoder runtime arguments check AztecProtocol/aztec-packages
1 participant
@benesjan