Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[devex] Revisit git hook format for circuits/barretenberg #1149

Closed
ludamad opened this issue Jul 22, 2023 · 1 comment · Fixed by #1946
Closed

[devex] Revisit git hook format for circuits/barretenberg #1149

ludamad opened this issue Jul 22, 2023 · 1 comment · Fixed by #1946

Comments

@ludamad
Copy link
Collaborator

ludamad commented Jul 22, 2023 •
edited
Loading

Currently I at least needed to disable this for barretenberg monorepo PR (with a filter) until there's cross team agreement about how to auto format style changes.
@github-project-automation github-project-automation bot moved this to Todo in A3 Jul 22, 2023
@ludamad
Copy link
Collaborator Author

ludamad commented Aug 1, 2023

One concrete flaw right now is that the barretenberg hook overwrites the circuits hook. They should at least play nice

@ludamad ludamad mentioned this issue Sep 2, 2023
Merged
ludamad added a commit that referenced this issue Sep 2, 2023
@ludamad
fix: format.sh issues (#1946)
f24814b 
Fixes #1149

After this:
- circuits hook will format barretenberg. This exception turned out not
to really be necessarily as they have the same formatting rules
- barretenberg hook doesn't break commits outside of barretenberg
@github-project-automation github-project-automation bot moved this from Todo to Done in A3 Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: format.sh issues AztecProtocol/aztec-packages
1 participant
@ludamad