Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C++] Enforce that all array inputs to circuits are properly formed circuit arrays (0s on right only) #1090

Closed
dbanks12 opened this issue Jul 17, 2023 · 0 comments · Fixed by #2519
Closed

[C++] Enforce that all array inputs to circuits are properly formed circuit arrays (0s on right only) #1090

dbanks12 opened this issue Jul 17, 2023 · 0 comments · Fixed by #2519
Assignees
@jeanmon
Labels
C-protocol-circuits Component: Protocol circuits (kernel & rollup)

Comments

@dbanks12
Copy link
Collaborator

No description provided.

@dbanks12 dbanks12 added the C-protocol-circuits Component: Protocol circuits (kernel & rollup) label Jul 17, 2023
@dbanks12 dbanks12 added this to A3 Jul 17, 2023
@github-project-automation github-project-automation bot moved this to Todo in A3 Jul 17, 2023
@ludamad ludamad changed the title Enforce that all array inputs to circuits are properly formed circuit arrays (0s on right only) [C++, Circuits] Enforce that all array inputs to circuits are properly formed circuit arrays (0s on right only) Jul 17, 2023
@ludamad ludamad changed the title [C++, Circuits] Enforce that all array inputs to circuits are properly formed circuit arrays (0s on right only) [C++] Enforce that all array inputs to circuits are properly formed circuit arrays (0s on right only) Jul 17, 2023
@jeanmon jeanmon self-assigned this Sep 25, 2023
@jeanmon jeanmon moved this from Todo to In Progress in A3 Sep 25, 2023
@jeanmon jeanmon mentioned this issue Sep 26, 2023
Merged
4 tasks
@jeanmon jeanmon moved this from In Progress to In Review in A3 Sep 28, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in A3 Sep 29, 2023
dbanks12 pushed a commit that referenced this issue Sep 29, 2023
@jeanmon
feat(1090): validate that some arrays are zero-padded on the right (#…
0327b54 
…2519)

Resolves #1090 

- Added a validation check for arrays to be zero-padded in
utils::array.hpp
- Activate this validation check in native private init and inner kernel
circuit on the following private_circuit_public_input members:
    - read_requests
    - return_values
    - new_commitments
    - new_nullifiers
    - nullified_commitments
    - private_call_stack
    - public_call_stack
    - new_l2_to_l1_msgs
- Unit tests on the validation routine and native private kernel
circuits
@jeanmon jeanmon mentioned this issue Oct 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeanmon jeanmon

Labels
C-protocol-circuits Component: Protocol circuits (kernel & rollup)
Projects
A3
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(1090): validate that some arrays are zero-padded on the right AztecProtocol/aztec-packages
2 participants
@dbanks12 @jeanmon