Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Witgen handles calls to non-existent contracts #10373

Closed
Tracked by #10044
dbanks12 opened this issue Dec 3, 2024 · 0 comments · Fixed by #10862
Closed
Tracked by #10044

Witgen handles calls to non-existent contracts #10373

dbanks12 opened this issue Dec 3, 2024 · 0 comments · Fixed by #10862
Assignees
@dbanks12

Comments

@dbanks12
Copy link
Collaborator

dbanks12 commented Dec 3, 2024

No description provided.

@dbanks12 dbanks12 mentioned this issue Dec 3, 2024
Open
@dbanks12 dbanks12 self-assigned this Dec 3, 2024
@dbanks12 dbanks12 mentioned this issue Dec 9, 2024
Closed
@dbanks12 dbanks12 mentioned this issue Dec 18, 2024
Merged
dbanks12 added a commit that referenced this issue Dec 19, 2024
@dbanks12
fix: handle calls to non-existent contracts in AVM witgen (#10862)
8820bd5 
Exceptionally halt & consume all gas on a call to a non-existent
contract. Should be able to prove.

Hacked this to work for top-level/enqueued-calls by adding a dummy row
(`op_add`) and then raising an exceptional halt.

Resolves #10373
Resolves #10044

Follow-up work:
- Add tests for bytecode deserialization failures (sim & witgen)
AztecBot pushed a commit to AztecProtocol/barretenberg that referenced this issue Dec 20, 2024
@dbanks12 @AztecBot
fix: handle calls to non-existent contracts in AVM witgen (#10862)
ecd21b1 
Exceptionally halt & consume all gas on a call to a non-existent
contract. Should be able to prove.

Hacked this to work for top-level/enqueued-calls by adding a dummy row
(`op_add`) and then raising an exceptional halt.

Resolves AztecProtocol/aztec-packages#10373
Resolves AztecProtocol/aztec-packages#10044

Follow-up work:
- Add tests for bytecode deserialization failures (sim & witgen)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dbanks12 dbanks12

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: handle calls to non-existent contracts in AVM witgen AztecProtocol/aztec-packages
1 participant
@dbanks12