Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove hack for bypassing contract class registration #10007

Open
spalladino opened this issue Nov 15, 2024 · 0 comments
Open

chore: Remove hack for bypassing contract class registration #10007

spalladino opened this issue Nov 15, 2024 · 0 comments
Labels
A-security Area: Relates to security. Something is insecure. team-alpha

Comments

@spalladino
Copy link
Collaborator

Undo everything done as part of #10000

@spalladino spalladino added A-security Area: Relates to security. Something is insecure. team-alpha labels Nov 15, 2024
spalladino added a commit that referenced this issue Nov 15, 2024
Skips emitting the event with the contract public bytecode when
registering the contract class. This allows for smaller L1 txs so they
fit in Sepolia. This is a temporary hack to be reverted.

To get bytecode into the nodes, we push it forcefully from the PXE
whenever we register a new contract. However, this only gets the
bytecode into the node that the PXE is connected to. To avoid nodes or
prover nodes from missing bytecode that is to be used for known
deployments, such as the token or token bridge contracts, we now
manually register them on initialization.

Reverting this is logged as issue #10007

Fixes #10000
spalladino added a commit that referenced this issue Nov 20, 2024
Skips emitting the event with the contract public bytecode when
registering the contract class. This allows for smaller L1 txs so they
fit in Sepolia. This is a temporary hack to be reverted.

To get bytecode into the nodes, we push it forcefully from the PXE
whenever we register a new contract. However, this only gets the
bytecode into the node that the PXE is connected to. To avoid nodes or
prover nodes from missing bytecode that is to be used for known
deployments, such as the token or token bridge contracts, we now
manually register them on initialization.

Reverting this is logged as issue #10007

Fixes #10000

Please read [contributing guidelines](CONTRIBUTING.md) and remove this
line.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-security Area: Relates to security. Something is insecure. team-alpha
Projects
None yet
Development

No branches or pull requests

1 participant