Skip to content

Commit

Permalink
fix: remove aztec.nr version check from noir-compiler (#3263)
Browse files Browse the repository at this point in the history
Removes bad check: noir-compiler's package.json never gets the latest
version in so it would always fail this check. Ideal case would be to
properly version aztec.nr and check against that version.
  • Loading branch information
alexghr authored Nov 7, 2023
1 parent 073782f commit e2e4775
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 6 deletions.
5 changes: 0 additions & 5 deletions yarn-project/noir-compiler/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ import { CompileOpts, NargoContractCompiler } from './compile/nargo.js';
import { FileManager } from './compile/noir/file-manager/file-manager.js';
import { NoirWasmCompileOptions, NoirWasmContractCompiler } from './compile/noir/noir-wasm-compiler.js';
import { generateContractArtifact } from './contract-interface-gen/abi.js';
import { AztecNrVersion } from './versions.js';

export * from './versions.js';

Expand Down Expand Up @@ -45,9 +44,5 @@ export async function compileUsingNoirWasm(
const artifacts = await compiler.compile();
const resolvedAztecNrVersion = compiler.getResolvedAztecNrVersion();

if (resolvedAztecNrVersion && AztecNrVersion !== resolvedAztecNrVersion) {
opts.log(`WARNING: Aztec.nr version mismatch: expected "${AztecNrVersion}", got "${resolvedAztecNrVersion}"`);
}

return artifacts.map(artifact => generateContractArtifact(artifact, resolvedAztecNrVersion));
}
1 change: 0 additions & 1 deletion yarn-project/noir-compiler/src/versions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import NoirVersion from './noir-version.json' assert { type: 'json' };
// read package.json at runtime instead of compile time so that we keep rootDir as-is in tsconfig
const pkg = JSON.parse(readFileSync(new URL('../package.json', import.meta.url), 'utf-8'));

export const AztecNrVersion = `aztec-packages-v${pkg.version}`;
export const NoirWasmVersion = pkg.dependencies['@noir-lang/noir_wasm'];
export const NoirTag = NoirVersion.tag;
export const NoirCommit = NoirVersion.commit;
Expand Down

0 comments on commit e2e4775

Please sign in to comment.