chore: ignore version 0 (the dead)

AztecProtocol · Jul 28, 2023 · be56a7e · be56a7e
1 parent 8358a48
commit be56a7e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/l1-contracts/src/core/messagebridge/Registry.sol b/l1-contracts/src/core/messagebridge/Registry.sol
@@ -123,7 +123,6 @@ contract Registry is IRegistry {
 
   function _getVersionFor(address _rollup) internal view returns (uint256 version, bool exists) {
     version = rollupToVersion[_rollup];
-    exists = version > 0 || snapshots[0].rollup == _rollup;
-    return (version, exists);
+    return (version, version > 0);
   }
 }
diff --git a/l1-contracts/test/Registry.t.sol b/l1-contracts/test/Registry.t.sol
@@ -30,8 +30,8 @@ contract RegistryTest is Test {
     assertEq(address(registry.getInbox()), DEAD);
     assertEq(address(registry.getOutbox()), DEAD);
 
-    uint256 version = registry.getVersionFor(DEAD);
-    assertEq(version, 0, "should have version 0 for dead rollup");
+    vm.expectRevert(abi.encodeWithSelector(Errors.Registry__RollupNotRegistered.selector, DEAD));
+    registry.getVersionFor(DEAD);
   }
 
   function testUpgrade() public {
@@ -55,6 +55,7 @@ contract RegistryTest is Test {
   }
 
   function testRevertUpgradeToSame() public {
+    registry.upgrade(DEAD, DEAD, DEAD);
     vm.expectRevert(abi.encodeWithSelector(Errors.Registry__RollupAlreadyRegistered.selector, DEAD));
     registry.upgrade(DEAD, DEAD, DEAD);
   }