Apply suggestions from code review

Co-authored-by: Santiago Palladino <[email protected]>

yarn-project/aztec/src/cli/cmds/start_prover_agent.ts

@@ -25,7 +25,7 @@ export async function startProverAgent(
     ...extractRelevantOptions<ProverAgentConfig>(options, proverAgentConfigMappings, 'proverAgent'), // override with command line options
   };
 
-  if (config.realProofs && (!config.bbBinaryPath || config.acvmBinaryPath)) {
+  if (config.realProofs && (!config.bbBinaryPath || !config.acvmBinaryPath)) {
     process.exit(1);
   }
 

yarn-project/prover-client/src/proving_broker/caching_broker_facade.ts

@@ -81,13 +81,13 @@ export class CachingBrokerFacade implements ServerCircuitProver {
 
     if (!jobEnqueued) {
       try {
-        await this.cache.setProvingJobStatus(id, { status: 'in-queue' });
         const inputsUri = await this.proofStore.saveProofInput(id, type, inputs);
         await this.broker.enqueueProvingJob({
           id,
           type,
           inputsUri,
         });
+        await this.cache.setProvingJobStatus(id, { status: 'in-queue' });
       } catch (err) {
         await this.cache.setProvingJobStatus(id, { status: 'not-found' });
         throw err;

yarn-project/prover-client/src/tx-prover/tx-prover.ts

@@ -99,7 +99,6 @@ export class TxProver implements EpochProverManager {
     }
     this.running = false;
     await this.stopAgents();
-    // TODO(palla/prover-node): Keep a reference to all proving orchestrators that are alive and stop them?
   }
 
   /**

yarn-project/prover-node/src/prover-cache/cache_manager.ts

@@ -37,7 +37,7 @@ export class ProverCacheManager {
     return new KVProverCache(store);
   }
 
-  public async removedStaleCaches(currentEpochNumber: bigint): Promise<void> {
+  public async removeStaleCaches(currentEpochNumber: bigint): Promise<void> {
     if (!this.cacheDir) {
       return;
     }