Skip to content

Commit

Permalink
chore(noir): silence warnings (#1544)
Browse files Browse the repository at this point in the history
Maddiaa0 authored Aug 11, 2023
1 parent 791f1cc commit ac1dc4b
Showing 6 changed files with 10 additions and 6 deletions.
2 changes: 1 addition & 1 deletion yarn-project/aztec.js/src/abis/ecdsa_account_contract.json

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -26,7 +26,7 @@ contract PublicToken {
let recipient_balance = storage.balances.at(recipient);
let new_amount = recipient_balance.read() + amount;
// TODO: Remove return value.
let hash = emit_unencrypted_log("Coins minted");
let _hash = emit_unencrypted_log("Coins minted");
recipient_balance.write(new_amount);
new_amount
}
@@ -50,7 +50,7 @@ contract PublicToken {
if (current_sender_balance as u126 > amount as u126) {
sender_balance.write(current_sender_balance - amount);
// TODO: Compiler complains if we don't assign the result of the write to anything
let hash = emit_unencrypted_log("Coins transferred");
let _hash = emit_unencrypted_log("Coins transferred");
let amount = current_recipient_balance + amount;
recipient_balance.write(amount);
amount
4 changes: 4 additions & 0 deletions yarn-project/noir-libs/noir-aztec/src/context.nr
Original file line number Diff line number Diff line change
@@ -174,10 +174,14 @@ impl Context {
}

fn accumulate_encrypted_logs<N>(&mut self, log: [Field; N]) {
let _void1 = self.inputs;
let _void2 = log;
// TODO(https://github.com/AztecProtocol/aztec-packages/issues/1165)
}

fn accumulate_unencrypted_logs<T>(&mut self, log: T) {
let _void1 = self.inputs;
let _void2 = log;
// TODO(https://github.com/AztecProtocol/aztec-packages/issues/1165)
}

2 changes: 1 addition & 1 deletion yarn-project/noir-libs/noir-aztec/src/oracle/storage.nr
Original file line number Diff line number Diff line change
@@ -28,5 +28,5 @@ unconstrained fn storage_write<N>(
storage_slot: Field,
fields: [Field; N]
) {
let hash = storage_write_oracle(storage_slot, fields);
let _hash = storage_write_oracle(storage_slot, fields);
}

0 comments on commit ac1dc4b

Please sign in to comment.