-
Notifications
You must be signed in to change notification settings - Fork 268
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore!: change ec_add to unsafe implementation (but much better perf) (…
…#8374) Use `unconditional_add` for ec_add ACIR opcode. This improves a lot the performance of the opcode, but also makes it unsafe. ~~I keep the PR as draft until aztec packages are sync with Noir PR noir-lang/noir#5858 which adds the checks in the stdlib function.~~ The unsafe version can then be used when we know the inputs are valid (for instance if they come from a previous add). n.b.: the real performance boost will happen when we will be able to use the unsafe version. Co-authored-by: Tom French <[email protected]>
- Loading branch information
1 parent
d5fd155
commit aabd2d8
Showing
3 changed files
with
50 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters