-
Notifications
You must be signed in to change notification settings - Fork 265
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: add documentation to
to_be_bytes, etc. (noir-lang/noir#5843)
feat: simplify constant calls to `poseidon2_permutation`, `schnorr_verify` and `embedded_curve_add` (noir-lang/noir#5140) chore: don't require empty `Prover.toml` for programs with zero arguments but a return value (noir-lang/noir#5845) fix!: Check unused generics are bound (noir-lang/noir#5840) chore(perf): Simplify poseidon2 algorithm (noir-lang/noir#5811) chore: redo typo PR by nnsW3 (noir-lang/noir#5834) fix(sha256): Perform compression per block and utilize ROM instead of RAM when setting up the message block (noir-lang/noir#5760) chore(perf): Update to stdlib keccak for reduced Brillig code size (noir-lang/noir#5827)
- Loading branch information
Showing
27 changed files
with
432 additions
and
54 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 86c151aa43ba990a0e900995064a88fc2ae6637d | ||
| c7473c6fcc6cbfd118b0352229ff86001cde3a64 |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
190 changes: 190 additions & 0 deletions
190
noir/noir-repo/compiler/noirc_evaluator/src/ssa/ir/instruction/call/blackbox.rs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,190 @@ | ||
| use std::rc::Rc; | ||
|
|
||
| use acvm::{acir::AcirField, BlackBoxFunctionSolver, BlackBoxResolutionError, FieldElement}; | ||
| use iter_extended::vecmap; | ||
|
|
||
| use crate::ssa::ir::{ | ||
| dfg::DataFlowGraph, instruction::SimplifyResult, types::Type, value::ValueId, | ||
| }; | ||
|
|
||
| use super::{array_is_constant, make_constant_array, to_u8_vec}; | ||
|
|
||
| pub(super) fn simplify_ec_add( | ||
| dfg: &mut DataFlowGraph, | ||
| solver: impl BlackBoxFunctionSolver<FieldElement>, | ||
| arguments: &[ValueId], | ||
| ) -> SimplifyResult { | ||
| match ( | ||
| dfg.get_numeric_constant(arguments[0]), | ||
| dfg.get_numeric_constant(arguments[1]), | ||
| dfg.get_numeric_constant(arguments[2]), | ||
| dfg.get_numeric_constant(arguments[3]), | ||
| dfg.get_numeric_constant(arguments[4]), | ||
| dfg.get_numeric_constant(arguments[5]), | ||
| ) { | ||
| ( | ||
| Some(point1_x), | ||
| Some(point1_y), | ||
| Some(point1_is_infinity), | ||
| Some(point2_x), | ||
| Some(point2_y), | ||
| Some(point2_is_infinity), | ||
| ) => { | ||
| let Ok((result_x, result_y, result_is_infinity)) = solver.ec_add( | ||
| &point1_x, | ||
| &point1_y, | ||
| &point1_is_infinity, | ||
| &point2_x, | ||
| &point2_y, | ||
| &point2_is_infinity, | ||
| ) else { | ||
| return SimplifyResult::None; | ||
| }; | ||
|
|
||
| let result_x = dfg.make_constant(result_x, Type::field()); | ||
| let result_y = dfg.make_constant(result_y, Type::field()); | ||
| let result_is_infinity = dfg.make_constant(result_is_infinity, Type::bool()); | ||
|
|
||
| let typ = Type::Array(Rc::new(vec![Type::field()]), 3); | ||
| let result_array = | ||
| dfg.make_array(im::vector![result_x, result_y, result_is_infinity], typ); | ||
|
|
||
| SimplifyResult::SimplifiedTo(result_array) | ||
| } | ||
| _ => SimplifyResult::None, | ||
| } | ||
| } | ||
|
|
||
| pub(super) fn simplify_poseidon2_permutation( | ||
| dfg: &mut DataFlowGraph, | ||
| solver: impl BlackBoxFunctionSolver<FieldElement>, | ||
| arguments: &[ValueId], | ||
| ) -> SimplifyResult { | ||
| match (dfg.get_array_constant(arguments[0]), dfg.get_numeric_constant(arguments[1])) { | ||
| (Some((state, _)), Some(state_length)) if array_is_constant(dfg, &state) => { | ||
| let state: Vec<FieldElement> = state | ||
| .iter() | ||
| .map(|id| { | ||
| dfg.get_numeric_constant(*id) | ||
| .expect("value id from array should point at constant") | ||
| }) | ||
| .collect(); | ||
|
|
||
| let Some(state_length) = state_length.try_to_u32() else { | ||
| return SimplifyResult::None; | ||
| }; | ||
|
|
||
| let Ok(new_state) = solver.poseidon2_permutation(&state, state_length) else { | ||
| return SimplifyResult::None; | ||
| }; | ||
|
|
||
| let result_array = make_constant_array(dfg, new_state, Type::field()); | ||
|
|
||
| SimplifyResult::SimplifiedTo(result_array) | ||
| } | ||
| _ => SimplifyResult::None, | ||
| } | ||
| } | ||
|
|
||
| pub(super) fn simplify_schnorr_verify( | ||
| dfg: &mut DataFlowGraph, | ||
| solver: impl BlackBoxFunctionSolver<FieldElement>, | ||
| arguments: &[ValueId], | ||
| ) -> SimplifyResult { | ||
| match ( | ||
| dfg.get_numeric_constant(arguments[0]), | ||
| dfg.get_numeric_constant(arguments[1]), | ||
| dfg.get_array_constant(arguments[2]), | ||
| dfg.get_array_constant(arguments[3]), | ||
| ) { | ||
| (Some(public_key_x), Some(public_key_y), Some((signature, _)), Some((message, _))) | ||
| if array_is_constant(dfg, &signature) && array_is_constant(dfg, &message) => | ||
| { | ||
| let signature = to_u8_vec(dfg, signature); | ||
| let signature: [u8; 64] = | ||
| signature.try_into().expect("Compiler should produce correctly sized signature"); | ||
|
|
||
| let message = to_u8_vec(dfg, message); | ||
|
|
||
| let Ok(valid_signature) = | ||
| solver.schnorr_verify(&public_key_x, &public_key_y, &signature, &message) | ||
| else { | ||
| return SimplifyResult::None; | ||
| }; | ||
|
|
||
| let valid_signature = dfg.make_constant(valid_signature.into(), Type::bool()); | ||
| SimplifyResult::SimplifiedTo(valid_signature) | ||
| } | ||
| _ => SimplifyResult::None, | ||
| } | ||
| } | ||
|
|
||
| pub(super) fn simplify_hash( | ||
| dfg: &mut DataFlowGraph, | ||
| arguments: &[ValueId], | ||
| hash_function: fn(&[u8]) -> Result<[u8; 32], BlackBoxResolutionError>, | ||
| ) -> SimplifyResult { | ||
| match dfg.get_array_constant(arguments[0]) { | ||
| Some((input, _)) if array_is_constant(dfg, &input) => { | ||
| let input_bytes: Vec<u8> = to_u8_vec(dfg, input); | ||
|
|
||
| let hash = hash_function(&input_bytes) | ||
| .expect("Rust solvable black box function should not fail"); | ||
|
|
||
| let hash_values = vecmap(hash, |byte| FieldElement::from_be_bytes_reduce(&[byte])); | ||
|
|
||
| let result_array = make_constant_array(dfg, hash_values, Type::unsigned(8)); | ||
| SimplifyResult::SimplifiedTo(result_array) | ||
| } | ||
| _ => SimplifyResult::None, | ||
| } | ||
| } | ||
|
|
||
| type ECDSASignatureVerifier = fn( | ||
| hashed_msg: &[u8], | ||
| public_key_x: &[u8; 32], | ||
| public_key_y: &[u8; 32], | ||
| signature: &[u8; 64], | ||
| ) -> Result<bool, BlackBoxResolutionError>; | ||
|
|
||
| pub(super) fn simplify_signature( | ||
| dfg: &mut DataFlowGraph, | ||
| arguments: &[ValueId], | ||
| signature_verifier: ECDSASignatureVerifier, | ||
| ) -> SimplifyResult { | ||
| match ( | ||
| dfg.get_array_constant(arguments[0]), | ||
| dfg.get_array_constant(arguments[1]), | ||
| dfg.get_array_constant(arguments[2]), | ||
| dfg.get_array_constant(arguments[3]), | ||
| ) { | ||
| ( | ||
| Some((public_key_x, _)), | ||
| Some((public_key_y, _)), | ||
| Some((signature, _)), | ||
| Some((hashed_message, _)), | ||
| ) if array_is_constant(dfg, &public_key_x) | ||
| && array_is_constant(dfg, &public_key_y) | ||
| && array_is_constant(dfg, &signature) | ||
| && array_is_constant(dfg, &hashed_message) => | ||
| { | ||
| let public_key_x: [u8; 32] = to_u8_vec(dfg, public_key_x) | ||
| .try_into() | ||
| .expect("ECDSA public key fields are 32 bytes"); | ||
| let public_key_y: [u8; 32] = to_u8_vec(dfg, public_key_y) | ||
| .try_into() | ||
| .expect("ECDSA public key fields are 32 bytes"); | ||
| let signature: [u8; 64] = | ||
| to_u8_vec(dfg, signature).try_into().expect("ECDSA signatures are 64 bytes"); | ||
| let hashed_message: Vec<u8> = to_u8_vec(dfg, hashed_message); | ||
|
|
||
| let valid_signature = | ||
| signature_verifier(&hashed_message, &public_key_x, &public_key_y, &signature) | ||
| .expect("Rust solvable black box function should not fail"); | ||
|
|
||
| let valid_signature = dfg.make_constant(valid_signature.into(), Type::bool()); | ||
| SimplifyResult::SimplifiedTo(valid_signature) | ||
| } | ||
| _ => SimplifyResult::None, | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.