fix: removal of setting private data root in kernel prover (#2671)

Resolves #778
AztecProtocol · Oct 5, 2023 · 8f792e3 · 8f792e3
1 parent 3feac8e
commit 8f792e3
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 9 deletions.
diff --git a/circuits/cpp/src/aztec3/circuits/kernel/private/native_private_kernel_circuit_init.cpp b/circuits/cpp/src/aztec3/circuits/kernel/private/native_private_kernel_circuit_init.cpp
@@ -27,10 +27,6 @@ void initialise_end_values(PrivateKernelInputsInit<NT> const& private_inputs,
     auto const& private_call_public_inputs = private_inputs.private_call.call_stack_item.public_inputs;
     auto const constants = CombinedConstantData<NT>{
         .block_data = private_call_public_inputs.historic_block_data,
-        // TODO(dbanks12): remove historic root from app circuit public inputs and
-        // add it to PrivateCallData: https://github.com/AztecProtocol/aztec-packages/issues/778
-        // Then use this:
-        // .private_data_tree_root = private_inputs.private_call.historic_private_data_tree_root,
         .tx_context = private_inputs.tx_request.tx_context,
     };
 

diff --git a/yarn-project/pxe/src/kernel_prover/kernel_prover.ts b/yarn-project/pxe/src/kernel_prover/kernel_prover.ts
@@ -138,11 +138,6 @@ export class KernelProver {
       );
 
       if (firstIteration) {
-        // TODO(https://github.com/AztecProtocol/aztec-packages/issues/778): remove historic root
-        // from app circuit public inputs and add it to PrivateCallData
-        privateCallData.callStackItem.publicInputs.historicBlockData.privateDataTreeRoot =
-          await this.oracle.getPrivateDataRoot();
-
         output = await this.proofCreator.createProofInit(new PrivateKernelInputsInit(txRequest, privateCallData));
       } else {
         const previousVkMembershipWitness = await this.oracle.getVkMembershipWitness(previousVerificationKey);