dirty fix

AztecProtocol · Jul 12, 2024 · 7dc34b0 · 7dc34b0
1 parent 2f7e8ac
commit 7dc34b0
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/barretenberg/cpp/src/barretenberg/numeric/uintx/uintx_impl.hpp b/barretenberg/cpp/src/barretenberg/numeric/uintx/uintx_impl.hpp
@@ -408,10 +408,14 @@ constexpr std::pair<uintx<base_uint>, uintx<base_uint>> uintx<base_uint>::barret
     uintx remainder = x - qm_lo;
 
     // because redc_parameter is an imperfect representation of 2^{2k} / n (might be too small),
-    // the computed quotient may be off by 1
-    if (remainder >= uintx(modulus)) {
+    // the computed quotient may be off by up to 3 (classic algorithm should be up to 1,
+    // TODO(https://github.com/AztecProtocol/barretenberg/issues/1051): investigate, why)
+    size_t i = 0;
+    while (remainder >= uintx(modulus)) {
+        ASSERT(i < 3);
         remainder = remainder - modulus;
         quotient = quotient + 1;
+        i++;
     }
     return std::make_pair(quotient, remainder);
 }