Skip to content

Commit

Permalink
Revert "Try just Ultra"
Browse files Browse the repository at this point in the history
This reverts commit 6b95005.
  • Loading branch information
codygunton committed Dec 12, 2023
1 parent 6b95005 commit 7999299
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ std::vector<uint8_t> AcirComposer::create_proof(acir_format::acir_format& constr
create_circuit_with_witness(builder_, constraint_system, witness);
info("gates: ", builder_.get_total_circuit_size());

// info("create_proof: ULTRA OPS SIZE = ", builder_.op_queue->ultra_ops.size());
info("create_proof: ULTRA OPS SIZE = ", builder_.op_queue->ultra_ops.size());

// WORKTODO: accumulate creates an instance and a pk, ignoring this one.
goblin = [&]() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ namespace acir_proofs {
*/
class AcirComposer {
public:
using Flavor = proof_system::honk::flavor::Ultra;
using Flavor = proof_system::honk::flavor::GoblinUltra;
// WORKTODO: it would be nice if we could just flip the flavor
// using Flavor = plonk::flavor::Ultra;
using ProvingKey = typename Flavor::ProvingKey;
Expand Down
8 changes: 4 additions & 4 deletions barretenberg/cpp/src/barretenberg/dsl/types.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -23,13 +23,13 @@

namespace acir_format {

using Builder = proof_system::UltraCircuitBuilder;
using Builder = proof_system::GoblinUltraCircuitBuilder;

using Composer = proof_system::honk::UltraComposer;
using Composer = proof_system::honk::GoblinUltraComposer;

using Prover = proof_system::honk::UltraProver;
using Prover = proof_system::honk::GoblinUltraProver;

using Verifier = proof_system::honk::UltraVerifier;
using Verifier = proof_system::honk::GoblinUltraVerifier;

using RecursiveProver = Prover;

Expand Down
6 changes: 3 additions & 3 deletions barretenberg/cpp/src/barretenberg/goblin/goblin.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ namespace barretenberg {

class Goblin {
using HonkProof = proof_system::plonk::proof;
using GUHFlavor = proof_system::honk::flavor::Ultra;
using GUHFlavor = proof_system::honk::flavor::GoblinUltra;
using GUHProvingKey = GUHFlavor::ProvingKey;
using GUHVerificationKey = GUHFlavor::VerificationKey;
using Commitment = GUHFlavor::Commitment;
Expand Down Expand Up @@ -57,10 +57,10 @@ class Goblin {
using Fq = barretenberg::fq;

using Transcript = proof_system::honk::BaseTranscript;
using GoblinUltraComposer = proof_system::honk::UltraComposer;
using GoblinUltraComposer = proof_system::honk::GoblinUltraComposer;
// LEFTOFF: create an Instance member
using GoblinUltraVerifier = proof_system::honk::UltraVerifier_<GUHFlavor>;
using GoblinUltraCircuitBuilder = proof_system::UltraCircuitBuilder;
using GoblinUltraCircuitBuilder = proof_system::GoblinUltraCircuitBuilder;
using OpQueue = proof_system::ECCOpQueue;
using ECCVMFlavor = proof_system::honk::flavor::ECCVM;
using ECCVMBuilder = proof_system::ECCVMCircuitBuilder<ECCVMFlavor>;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,5 @@ std::array<typename bn254<CircuitBuilder>::Element, 2> MergeRecursiveVerifier_<C
}

template class MergeRecursiveVerifier_<GoblinUltraCircuitBuilder>;
template class MergeRecursiveVerifier_<UltraCircuitBuilder>;

} // namespace proof_system::plonk::stdlib::recursion::goblin
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,5 @@ template <typename CircuitBuilder> class MergeRecursiveVerifier_ {
};

extern template class MergeRecursiveVerifier_<GoblinUltraCircuitBuilder>;
extern template class MergeRecursiveVerifier_<UltraCircuitBuilder>;

} // namespace proof_system::plonk::stdlib::recursion::goblin

0 comments on commit 7999299

Please sign in to comment.