Skip to content

Commit

Permalink
add comment with issue
Browse files Browse the repository at this point in the history
  • Loading branch information
sirasistant committed Sep 24, 2024
1 parent 5cbfd82 commit 6d1235c
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 23 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -638,8 +638,6 @@ BlockConstraint handle_memory_init(Program::Opcode::MemoryInit const& mem_init)
block.type = BlockType::ReturnData;
}

info("DSL: BLOCK TYPE = ", block.type);

return block;
}

Expand Down Expand Up @@ -704,10 +702,6 @@ AcirFormat circuit_serde_to_acir_format(Program::Circuit const& circuit, bool ho
gate.value);
}
for (const auto& [block_id, block] : block_id_to_block_constraint) {
info("HERE: block type = ", block.first.type);
if (block.first.type == 2) {
info("Trace size = ", block.first.trace.size());
}
// Note: the trace will always be empty for ReturnData since it cannot be explicitly read from in noir
if (!block.first.trace.empty() || block.first.type == BlockType::ReturnData ||
block.first.type == BlockType::CallData) {
Expand Down
31 changes: 14 additions & 17 deletions yarn-project/ivc-integration/src/client_ivc_integration.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,13 @@ import path from 'path';
import { fileURLToPath } from 'url';

import {
MOCK_MAX_COMMITMENTS_PER_TX,
MockAppCreatorCircuit,
MockAppReaderCircuit,
MockPrivateKernelInitCircuit,
MockPrivateKernelInnerCircuit,
MockPrivateKernelResetCircuit,
MockPrivateKernelTailCircuit,
witnessGenCreatorAppMockCircuit,
witnessGenMockPrivateKernelInitCircuit,
witnessGenMockPrivateKernelInnerCircuit,
witnessGenMockPrivateKernelResetCircuit,
witnessGenMockPrivateKernelTailCircuit,
witnessGenReaderAppMockCircuit,
} from './index.js';

Expand Down Expand Up @@ -127,19 +122,21 @@ describe('Client IVC Integration', () => {
app_inputs: readerAppWitnessGenResult.publicInputs,
});

const resetWitnessGenResult = await witnessGenMockPrivateKernelResetCircuit({
prev_kernel_public_inputs: innerWitnessGenResult.publicInputs,
commitment_read_hints: [
'0x1', // Reader reads commitment 0x2, which is at index 1 of the created commitments
MOCK_MAX_COMMITMENTS_PER_TX.toString(), // Pad with no-ops
MOCK_MAX_COMMITMENTS_PER_TX.toString(),
MOCK_MAX_COMMITMENTS_PER_TX.toString(),
],
});
// TODO: https://github.com/AztecProtocol/barretenberg/issues/1111 - Add back reset and tail when this is fixed.

const tailWitnessGenResult = await witnessGenMockPrivateKernelTailCircuit({
prev_kernel_public_inputs: resetWitnessGenResult.publicInputs,
});
// const resetWitnessGenResult = await witnessGenMockPrivateKernelResetCircuit({
// prev_kernel_public_inputs: innerWitnessGenResult.publicInputs,
// commitment_read_hints: [
// '0x1', // Reader reads commitment 0x2, which is at index 1 of the created commitments
// MOCK_MAX_COMMITMENTS_PER_TX.toString(), // Pad with no-ops
// MOCK_MAX_COMMITMENTS_PER_TX.toString(),
// MOCK_MAX_COMMITMENTS_PER_TX.toString(),
// ],
// });

// const tailWitnessGenResult = await witnessGenMockPrivateKernelTailCircuit({
// prev_kernel_public_inputs: resetWitnessGenResult.publicInputs,
// });

// Create client IVC proof
const bytecodes = [
Expand Down

0 comments on commit 6d1235c

Please sign in to comment.