-
Notifications
You must be signed in to change notification settings - Fork 243
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
8849: codegen recursive_verifier.cpp
- Loading branch information
Showing
8 changed files
with
194 additions
and
6 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 2 additions & 1 deletion
3
.../avm/recursion/avm_recursive_verifier.cpp → ...g/vm/avm/generated/recursive_verifier.cpp
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
2 changes: 1 addition & 1 deletion
2
.../avm/recursion/avm_recursive_verifier.hpp → ...g/vm/avm/recursion/recursive_verifier.hpp
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
158 changes: 158 additions & 0 deletions
158
bb-pilcom/bb-pil-backend/templates/recursive_verifier.cpp.hbs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,158 @@ | ||
| // AUTOGENERATED FILE | ||
| #include "barretenberg/vm/{{snakeCase name}}/recursion/recursive_verifier.hpp" | ||
| #include "barretenberg/commitment_schemes/zeromorph/zeromorph.hpp" | ||
| #include "barretenberg/plonk_honk_shared/types/aggregation_object_type.hpp" | ||
| #include "barretenberg/polynomials/polynomial.hpp" | ||
| #include "barretenberg/polynomials/shared_shifted_virtual_zeroes_array.hpp" | ||
| #include "barretenberg/stdlib/primitives/field/field.hpp" | ||
| #include "barretenberg/transcript/transcript.hpp" | ||
| #include "barretenberg/vm/aztec_constants.hpp" | ||
| #include <algorithm> | ||
| #include <cstddef> | ||
| #include <memory> | ||
|
|
||
| namespace bb { | ||
|
|
||
| template <typename Flavor> | ||
| {{name}}RecursiveVerifier_<Flavor>::{{name}}RecursiveVerifier_( | ||
| Builder* builder, const std::shared_ptr<NativeVerificationKey>& native_verification_key) | ||
| : key(std::make_shared<VerificationKey>(builder, native_verification_key)) | ||
| , builder(builder) | ||
| {} | ||
|
|
||
| template <typename Flavor> | ||
| {{name}}RecursiveVerifier_<Flavor>::{{name}}RecursiveVerifier_(Builder* builder, const std::shared_ptr<VerificationKey>& vkey) | ||
| : key(vkey) | ||
| , builder(builder) | ||
| {} | ||
|
|
||
| // Evaluate the given public input column over the multivariate challenge points | ||
| template <typename Flavor> | ||
| Flavor::FF {{name}}RecursiveVerifier_<Flavor>::evaluate_public_input_column(const std::vector<FF>& points, | ||
| const std::vector<FF>& challenges) | ||
| { | ||
| auto coefficients = SharedShiftedVirtualZeroesArray<FF>{ | ||
| .start_ = 0, | ||
| .end_ = points.size(), | ||
| .virtual_size_ = key->circuit_size, // NOLINTNEXTLINE(cppcoreguidelines-avoid-c-arrays) | ||
| .backing_memory_ = std::static_pointer_cast<FF[]>(get_mem_slab(sizeof(FF) * points.size())), | ||
| }; | ||
|
|
||
| memcpy( | ||
| static_cast<void*>(coefficients.data()), static_cast<const void*>(points.data()), sizeof(FF) * points.size()); | ||
|
|
||
| return generic_evaluate_mle<FF>(challenges, coefficients); | ||
| } | ||
|
|
||
| template <typename Flavor> | ||
| {{name}}RecursiveVerifier_<Flavor>::AggregationObject {{name}}RecursiveVerifier_<Flavor>::verify_proof( | ||
| const HonkProof& proof, const std::vector<std::vector<bb::fr>>& public_inputs_vec_nt, AggregationObject agg_obj) | ||
| { | ||
| StdlibProof<Builder> stdlib_proof = bb::convert_proof_to_witness(builder, proof); | ||
|
|
||
| std::vector<std::vector<FF>> public_inputs_ct; | ||
| public_inputs_ct.reserve(public_inputs_vec_nt.size()); | ||
|
|
||
| for (const auto& vec : public_inputs_vec_nt) { | ||
| std::vector<FF> vec_ct; | ||
| vec_ct.reserve(vec.size()); | ||
| for (const auto& el : vec) { | ||
| vec_ct.push_back(bb::stdlib::witness_t<Builder>(builder, el)); | ||
| } | ||
| public_inputs_ct.push_back(vec_ct); | ||
| } | ||
|
|
||
| return verify_proof(stdlib_proof, public_inputs_ct, agg_obj); | ||
| } | ||
|
|
||
| // TODO(#991): (see https://github.com/AztecProtocol/barretenberg/issues/991) | ||
| template <typename Flavor> | ||
| {{name}}RecursiveVerifier_<Flavor>::AggregationObject {{name}}RecursiveVerifier_<Flavor>::verify_proof( | ||
| const StdlibProof<Builder>& stdlib_proof, | ||
| const std::vector<std::vector<FF>>& public_inputs, | ||
| AggregationObject agg_obj) | ||
| { | ||
| using Curve = typename Flavor::Curve; | ||
| using Zeromorph = ZeroMorphVerifier_<Curve>; | ||
| using PCS = typename Flavor::PCS; | ||
| using VerifierCommitments = typename Flavor::VerifierCommitments; | ||
| using CommitmentLabels = typename Flavor::CommitmentLabels; | ||
| using RelationParams = ::bb::RelationParameters<typename Flavor::FF>; | ||
| using Transcript = typename Flavor::Transcript; | ||
|
|
||
| transcript = std::make_shared<Transcript>(stdlib_proof); | ||
|
|
||
| RelationParams relation_parameters; | ||
| VerifierCommitments commitments{ key }; | ||
| CommitmentLabels commitment_labels; | ||
|
|
||
| const auto circuit_size = transcript->template receive_from_prover<FF>("circuit_size"); | ||
| if (static_cast<uint32_t>(circuit_size.get_value()) != key->circuit_size) { | ||
| throw_or_abort("{{name}}RecursiveVerifier::verify_proof: proof circuit size does not match verification key!"); | ||
| } | ||
|
|
||
| // Get commitments to VM wires | ||
| for (auto [comm, label] : zip_view(commitments.get_wires(), commitment_labels.get_wires())) { | ||
| comm = transcript->template receive_from_prover<Commitment>(label); | ||
| } | ||
|
|
||
| auto [beta, gamma] = transcript->template get_challenges<FF>("beta", "gamma"); | ||
| relation_parameters.beta = beta; | ||
| relation_parameters.gamma = gamma; | ||
|
|
||
| // Get commitments to inverses | ||
| for (auto [label, commitment] : zip_view(commitment_labels.get_derived(), commitments.get_derived())) { | ||
| commitment = transcript->template receive_from_prover<Commitment>(label); | ||
| } | ||
|
|
||
| // unconstrained | ||
| const size_t log_circuit_size = numeric::get_msb(static_cast<uint32_t>(circuit_size.get_value())); | ||
| auto sumcheck = SumcheckVerifier<Flavor>(log_circuit_size, transcript); | ||
|
|
||
| FF alpha = transcript->template get_challenge<FF>("Sumcheck:alpha"); | ||
|
|
||
| auto gate_challenges = std::vector<FF>(log_circuit_size); | ||
| for (size_t idx = 0; idx < log_circuit_size; idx++) { | ||
| gate_challenges[idx] = transcript->template get_challenge<FF>("Sumcheck:gate_challenge_" + std::to_string(idx)); | ||
| } | ||
|
|
||
| // No need to constrain that sumcheck_verified is true as this is guaranteed by the implementation of | ||
| // when called over a "circuit field" types. | ||
| auto [multivariate_challenge, claimed_evaluations, sumcheck_verified] = | ||
| sumcheck.verify(relation_parameters, alpha, gate_challenges); | ||
|
|
||
| vinfo("verified sumcheck: ", (sumcheck_verified.has_value() && sumcheck_verified.value())); | ||
|
|
||
| // Public columns evaluation checks | ||
| std::vector<FF> mle_challenge(multivariate_challenge.begin(), | ||
| multivariate_challenge.begin() + static_cast<int>(log_circuit_size)); | ||
|
|
||
| {{#each public_cols}} | ||
| FF {{col}}_evaluation = evaluate_public_input_column(public_inputs[{{idx}}], mle_challenge); | ||
| {{col}}_evaluation.assert_equal(claimed_evaluations.{{col}}, | ||
| "{{col}}_evaluation failed"); | ||
|
|
||
| {{/each}} | ||
|
|
||
| auto opening_claim = Zeromorph::verify(circuit_size, | ||
| commitments.get_unshifted(), | ||
| commitments.get_to_be_shifted(), | ||
| claimed_evaluations.get_unshifted(), | ||
| claimed_evaluations.get_shifted(), | ||
| multivariate_challenge, | ||
| Commitment::one(builder), | ||
| transcript); | ||
|
|
||
| auto pairing_points = PCS::reduce_verify(opening_claim, transcript); | ||
|
|
||
| pairing_points[0] = pairing_points[0].normalize(); | ||
| pairing_points[1] = pairing_points[1].normalize(); | ||
| // TODO(https://github.com/AztecProtocol/barretenberg/issues/995): generate this challenge properly. | ||
| typename Curve::ScalarField recursion_separator = | ||
| Curve::ScalarField::from_witness_index(builder, builder->add_variable(42)); | ||
| agg_obj.aggregate(pairing_points, recursion_separator); | ||
| return agg_obj; | ||
| } | ||
|
|
||
| template class {{name}}RecursiveVerifier_<{{name}}RecursiveFlavor_<UltraCircuitBuilder>>; | ||
| } // namespace bb |