Skip to content

Commit

Permalink
clarifying arg name
Browse files Browse the repository at this point in the history
  • Loading branch information
benesjan committed Mar 22, 2024
1 parent 20536d3 commit 65ae341
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions l1-contracts/src/core/interfaces/messagebridge/IInbox.sol
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@ import {DataStructures} from "../../libraries/DataStructures.sol";
interface IInbox {
/**
* @notice Emitted when a message is sent
* @param blockNumber - The block number in which the message is included
* @param l2BlockNumber - The L2 block number in which the message is included
* @param index - The index of the message in the block
* @param hash - The hash of the message
*/
event MessageSent(uint256 indexed blockNumber, uint256 index, bytes32 hash);
event MessageSent(uint256 indexed l2BlockNumber, uint256 index, bytes32 hash);

// docs:start:send_l1_to_l2_message
/**
Expand Down
4 changes: 2 additions & 2 deletions yarn-project/archiver/src/archiver/archiver.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -198,14 +198,14 @@ function makeTxsPublishedEvent(l1BlockNum: bigint, txsEffectsHash: Buffer) {
/**
* Makes fake L1ToL2 MessageSent events for testing purposes.
* @param l1BlockNum - L1 block number.
* @param l2BlockNumber - The L2 block number of the leaf inserted.
* @param l2BlockNumber - The L2 block number of in which the message was included.
* @returns MessageSent event logs.
*/
function makeMessageSentEvent(l1BlockNum: bigint, l2BlockNumber: bigint, index: bigint) {
return {
blockNumber: l1BlockNum,
args: {
blockNumber: l2BlockNumber,
l2BlockNumber,
index,
hash: Fr.random().toString(),
},
Expand Down
4 changes: 2 additions & 2 deletions yarn-project/archiver/src/archiver/eth_log_handlers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ export function processMessageSentLogs(
): InboxLeaf[] {
const leaves: InboxLeaf[] = [];
for (const log of logs) {
const { blockNumber, index, hash } = log.args;
leaves.push(new InboxLeaf(blockNumber, index, Fr.fromString(hash)));
const { l2BlockNumber, index, hash } = log.args;
leaves.push(new InboxLeaf(l2BlockNumber, index, Fr.fromString(hash)));
}
return leaves;
}
Expand Down

0 comments on commit 65ae341

Please sign in to comment.