Skip to content

Commit

Permalink
chore: Do not aggregate note decryption time for benchmarks (#6032)
Browse files Browse the repository at this point in the history
Note decryption times have been varying wildly since they are small, and
we don't get much precision out of our runners, so we just remove them
from benchmarks for now. Note that they are still output to logs.
  • Loading branch information
spalladino authored Apr 26, 2024
1 parent ab36d7e commit 658a880
Showing 1 changed file with 1 addition and 12 deletions.
13 changes: 1 addition & 12 deletions yarn-project/scripts/src/benchmarks/aggregate.ts
Original file line number Diff line number Diff line change
Expand Up @@ -106,23 +106,12 @@ function processCircuitSimulation(entry: CircuitSimulationStats, results: Benchm

/**
* Processes an entry with event name 'note-processor-caught-up' and updates results
* Buckets are rollup sizes for NOTE_DECRYPTING_TIME, or chain sizes for NOTE_HISTORY_DECRYPTING_TIME
*/
function processNoteProcessorCaughtUp(entry: NoteProcessorCaughtUpStats, results: BenchmarkCollectedResults) {
const { seen, decrypted, blocks, duration, dbSize } = entry;
if (BENCHMARK_BLOCK_SIZES.includes(decrypted)) {
append(results, 'note_successful_decrypting_time_in_ms', decrypted, duration);
}
if (BENCHMARK_BLOCK_SIZES.includes(seen) && decrypted === 0) {
append(results, 'note_trial_decrypting_time_in_ms', seen, duration);
}
const { decrypted, blocks, dbSize } = entry;
if (BENCHMARK_HISTORY_CHAIN_LENGTHS.includes(blocks) && decrypted > 0) {
append(results, 'note_history_successful_decrypting_time_in_ms', blocks, duration);
append(results, 'pxe_database_size_in_bytes', blocks, dbSize);
}
if (BENCHMARK_HISTORY_CHAIN_LENGTHS.includes(blocks) && decrypted === 0) {
append(results, 'note_history_trial_decrypting_time_in_ms', blocks, duration);
}
}

/** Processes an entry with event name 'l2-block-built' and updates results where buckets are rollup sizes */
Expand Down

0 comments on commit 658a880

Please sign in to comment.